Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:32037
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.184 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=eBRwbx8noFaBQcj/75JFMYKWKTWIqYUtCqahKYsPb1Wh6wQ4EqEkwf52u/qTu+MhPki8fhI/N5bzEDwkcAnguovOhTP+ZrIOd9da6frSf/wlmTlxC5tJ0qN7r9dhzwrkIVA4mjYYE7d2zWbrZ95JoCwrhVdoO+x+vF8u63tTSLQ=
Message-ID: <ee59b7580709040835v65705d05y39563122d36ec738@mail.gmail.com>
Date: Tue, 4 Sep 2007 23:35:58 +0800
To: "Nuno Lopes" <nlopess@php.net>
Cc: internals@lists.php.net, andi@php.net, dmitry@php.net
In-Reply-To: <20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <ee59b7580709040724y23427c4bq2f6cd3b2ee409276@mail.gmail.com>
	 <20070904162613.4qgfdddo7scw8o8w@w13.mail.sapo.pt>
Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref
From: planetbeing@gmail.com ("David Wang")

> About the patch, the zval_*_p() functions don't really need to exist..
> they can be macros as well.

As I said, if those were macros, it would be very difficult to squeeze
more than one statement into them.

Consider the usage in Zend/zend_execute.c:

        if (!Z_DELREF_P(z)) {
                Z_SET_REFCOUNT_P(z, 1);

Suppose I wanted to do the following in Z_DELREF_P(z):
"some_function(z); z->refcount--;" Defining the macro as that would
break that section of the code. Also, suppose I have code like this:

       if(some_condition) {
            Z_DELREF_P(z);

Having multiple statements in Z_DELREF_P will also break that code. It
seems to me inline functions are the best solution (the second best
solution would be to put braces around the statements in the define,
but then no return value would be possible).

> (and the online keyword is also handled by
> the Zend engine)

Do you mean ZEND_VM_ALWAYS_INLINE? There is a ZEND_VM_ALWAYS_INLINE
#define that does something similar to my "always_inline". However, it
doesn't work for Microsoft compilers, and since it doesn't include the
"inline" keyword within its definition, I'd have to change the meaning
of it in order to fix that. As far as I can tell, it's not referenced
by any code at all, but that still might be a bad idea.