Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31990 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43370 invoked by uid 1010); 30 Aug 2007 19:32:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 43355 invoked from network); 30 Aug 2007 19:32:40 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 Aug 2007 19:32:40 -0000 Authentication-Results: pb1.pair.com header.from=antony@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=antony@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: antony@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:37855] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7F/B1-35128-75B17D64 for ; Thu, 30 Aug 2007 15:32:40 -0400 Received: (qmail 20692 invoked from network); 30 Aug 2007 19:32:36 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 30 Aug 2007 19:32:36 -0000 Message-ID: <46D71B55.3030207@zend.com> Date: Thu, 30 Aug 2007 23:32:37 +0400 User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stanislav Malyshev CC: php-dev References: <46D6BE5F.8060900@zend.com> <46D71A36.2060603@zend.com> In-Reply-To: <46D71A36.2060603@zend.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] disallow arguments by ref in magic methods From: antony@zend.com (Antony Dovgal) On 30.08.2007 23:27, Stanislav Malyshev wrote: >> Expected result of this code is: >> Fatal error: Method test::__set() cannot take arguments by reference in %s on line %d > > I'd make it a warning. As far as I can see, declaring __set with > references doesn't do anything bad, just reference thing doesn't work > (correct me here if I'm wrong). So why should we produce fatal error? The method call doesn't work in this case, it fails with fatal error, just try the example I posted. Everything else is just fine, yeah.. -- Wbr, Antony Dovgal