Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31985
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
To: "'Antony Dovgal'" <antony@zend.com>,
	"'php-dev'" <internals@lists.php.net>
Date: Thu, 30 Aug 2007 17:46:50 +0400
Message-ID: <000401c7eb0c$3857edd0$6e02a8c0@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <46D6BE5F.8060900@zend.com>
Importance: Normal
Subject: RE: [PHP-DEV] [PATCH] disallow arguments by ref in magic methods
From: dmitry@zend.com ("Dmitry Stogov")
References: <46D6BE5F.8060900@zend.com>

I like this patch. It prevents stupid errors.
ZE always passes arguments to magic methods by value so they never may be
modified.

Thanks. Dmitry.


> -----Original Message-----
> From: Antony Dovgal [mailto:antony@zend.com] 
> Sent: Thursday, August 30, 2007 4:56 PM
> To: php-dev
> Subject: [PHP-DEV] [PATCH] disallow arguments by ref in magic methods
> 
> 
> Hello.
> 
> I'd like to commit these two patches (for HEAD and 5_2 
> appropriately). The patches disallow declaring any magic 
> methods as accepting arguments by ref (which makes no sense anyway).
> 
> Example:
> <?php
> class test {
>     function __set(&$name, $val) { }
> }
> 
> $t = new test;
> $name = "prop";
> $t->$name = 1;
> ?>
> 
> Expected result of this code is:
> Fatal error: Method test::__set() cannot take arguments by 
> reference in %s on line %d
> 
> 
> The diffs:
> http://dev.daylessday.org/diff/magic_by_ref_5_2.diff
> http://dev.daylessday.org/diff/magic_by_ref_HEAD.diff
> 
> If there are no objections, I'm going to commit them later in 
> the evening.
> 
> -- 
> Wbr, 
> Antony Dovgal
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>