Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31983
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <46D6BE5F.8060900@zend.com>
Date: Thu, 30 Aug 2007 16:55:59 +0400
User-Agent: Thunderbird 2.0.0.6 (X11/20070801)
MIME-Version: 1.0
To: php-dev <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: [PATCH] disallow arguments by ref in magic methods
From: antony@zend.com (Antony Dovgal)

Hello.

I'd like to commit these two patches (for HEAD and 5_2 appropriately).
The patches disallow declaring any magic methods as accepting arguments by ref (which makes no sense anyway).

Example:
<?php
class test {
    function __set(&$name, $val) { }
}

$t = new test;
$name = "prop";
$t->$name = 1;
?>

Expected result of this code is:
Fatal error: Method test::__set() cannot take arguments by reference in %s on line %d


The diffs:
http://dev.daylessday.org/diff/magic_by_ref_5_2.diff
http://dev.daylessday.org/diff/magic_by_ref_HEAD.diff

If there are no objections, I'm going to commit them later in the evening.

-- 
Wbr, 
Antony Dovgal