Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31759
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <46CA6367.9090301@lerdorf.com>
Date: Mon, 20 Aug 2007 21:00:39 -0700
User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728)
MIME-Version: 1.0
To: Jani Taskinen <jani.taskinen@iki.fi>
CC:  david.coallier@nyphp.com, Gregory Beaver <greg@chiaraquartet.net>,
        internals Mailing List <internals@lists.php.net>
References: <46C9F217.8040804@chiaraquartet.net> <b5f7bf6c0708201306id6ae99i5bf821f9d273be85@mail.gmail.com> <46C9F50A.7040009@sci.fi>
In-Reply-To: <46C9F50A.7040009@sci.fi>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] allowing multiple namespaces per file plus
 namespaces with brackets
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Sheez, guys, slow down a tad.  Just because he says "no performance
penalty" in the description, doesn't make it true.  Unless I missed
something in the patch, I don't see how I would resolve the symbols at
compile-time now which means it has been moved to the executor and in
doing so it implies a huge performance penalty.

-Rasmus

Jani Taskinen wrote:
> This is the wrong way to do things around here.
> If you want something in, just commit and ignore the noise on this list.
> 
> --Jani
> 
> david.coallier@nyphp.com kirjoitti:
>> Thanks. someone please commit that as fast as posible so no one can
>> say anything
>>
>> ;-)
>>
>> On 8/20/07, Gregory Beaver <greg@chiaraquartet.net> wrote:
>>> Hi all,
>>>
>>> This patch is also available at
>>> http://pear.php.net/~greg/namespace.patch.txt
>>>
>>> The patch adds the syntax "namespace { *stuff }" and allows multiple
>>> namespaces per file with no performance penalty or added complexity as
>>> only 4 lines of code need to be changed, and 9 lines of code added to
>>> implement this support!
>>>
>>> Basically, there is one use case of multiple namespaces per file that
>>> the patch is designed to support, which is the ability to cram many
>>> files into a single file.  I have done this for purposes of distributing
>>> things (prior to phar), it is used by some with phing tasks for
>>> performance reasons, and can have other uses as well.
>>>
>>> The patch provides the ability to do this, for example:
>>>
>>> <?php
>>> namespace One {
>>>     require_once 'blah.php';
>>>     class MyClass extends blah
>>>     {
>>>         function test()
>>>         {
>>>             echo "OK\n";
>>>         }
>>>     }
>>>     function test()
>>>     {
>>>         echo "OK\n";
>>>     }
>>> }
>>>
>>> namespace Two {
>>>     class MyClass
>>>     {
>>>         function test()
>>>         {
>>>             echo "OK\n";
>>>         }
>>>     }
>>>     function test()
>>>     {
>>>         echo "OK\n";
>>>     }
>>> }
>>> ?>
>>>
>>> Note that the old format "namespace OneRingToRuleThemAll;" is still
>>> fully supported, and should be the recommended format, as build tools
>>> can easily take an entire file, change namespace .*; into namespace .*{
>>> and append <?php } ?> to the end of the file.
>>>
>>> The attached patch is against php6, but as you can see, a blind monkey
>>> could port it to PHP_5_3 when the time comes.  All of the introduced
>>> changes are now tested, including the error message for nested namespace
>>> declarations, and the error message for multiple namespace declarations
>>> with ; (which was previously untested by .phpt tests)
>>>
>>> Thanks,
>>> Greg
>>>
>>
>>
>