Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31710 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88939 invoked by uid 1010); 17 Aug 2007 18:54:58 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 88924 invoked from network); 17 Aug 2007 18:54:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Aug 2007 18:54:58 -0000 Authentication-Results: pb1.pair.com header.from=greg@chiaraquartet.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=greg@chiaraquartet.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain chiaraquartet.net from 38.99.98.18 cause and error) X-PHP-List-Original-Sender: greg@chiaraquartet.net X-Host-Fingerprint: 38.99.98.18 beast.bluga.net Linux 2.6 Received: from [38.99.98.18] ([38.99.98.18:34939] helo=mail.bluga.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 40/20-21447-10FE5C64 for ; Fri, 17 Aug 2007 14:54:57 -0400 Received: from mail.bluga.net (localhost.localdomain [127.0.0.1]) by mail.bluga.net (Postfix) with ESMTP id 99C5194DC8D; Fri, 17 Aug 2007 11:54:54 -0700 (MST) Received: from [192.168.0.106] (CPE-76-84-1-170.neb.res.rr.com [76.84.1.170]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.bluga.net (Postfix) with ESMTP id 7EA3794DC7B; Fri, 17 Aug 2007 11:54:52 -0700 (MST) Message-ID: <46C5EF82.4010007@chiaraquartet.net> Date: Fri, 17 Aug 2007 13:57:06 -0500 User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: Antony Dovgal CC: php-dev , 'Ilia Alshanetsky' References: <46C19531.7020003@zend.com> <46C59114.4000102@zend.com> In-Reply-To: <46C59114.4000102@zend.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [PHP-DEV] [Fwd: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c] From: greg@chiaraquartet.net (Gregory Beaver) Antony Dovgal wrote: > > Ilia? Greg? > Any comments? > > On 14.08.2007 15:42, Antony Dovgal wrote: >> This patch breaks PEAR phar install on 64bit. >>> From what I can see in the source code, it compares data in the phar >>> with >> the result of sprintf("%u"..), which is different on 32bit and 64bit >> because of this patch. >> >> Either phar should be changed to detect this situation or this patch >> should be reverted. Hi, My only comment is I've already been forced to change a fully working PHP_Archive 3 times because of bugfixes that broke BC in pack/unpack, and I changed it to sprintf("%u") because it was the only way to ensure that the behavior works the same way on 32-bit and 64-bit. I would appreciate it if this is the last change of this nature that I need to deal with :). As for PHP_Archive, I'll try to figure out a solution but to be honest, I'm not too keen on this, as sprintf("%u") was the only solution I found last time. Perhaps dropping unpack() and rewriting it in userspace is my only option . Thanks, Greg P.S. just to be clear, this is PHP_Archive we're talking about, not phar. phar is a PHP extension that has no such problems as it does all the unpacking internally, PHP_Archive is a userspace stream wrapper that uses unpack()/sprintf("%u")