Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31673 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39328 invoked by uid 1010); 17 Aug 2007 12:14:18 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 39313 invoked from network); 17 Aug 2007 12:14:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Aug 2007 12:14:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=antony@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=antony@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: antony@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:27753] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/D1-28909-61195C64 for ; Fri, 17 Aug 2007 08:14:17 -0400 Received: (qmail 11969 invoked from network); 17 Aug 2007 12:14:11 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 17 Aug 2007 12:14:11 -0000 Message-ID: <46C59114.4000102@zend.com> Date: Fri, 17 Aug 2007 16:14:12 +0400 User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: php-dev CC: 'Ilia Alshanetsky' , Gregory Beaver References: <46C19531.7020003@zend.com> In-Reply-To: <46C19531.7020003@zend.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [Fwd: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c] From: antony@zend.com (Antony Dovgal) Ilia? Greg? Any comments? On 14.08.2007 15:42, Antony Dovgal wrote: > This patch breaks PEAR phar install on 64bit. >>From what I can see in the source code, it compares data in the phar with > the result of sprintf("%u"..), which is different on 32bit and 64bit because of this patch. > > Either phar should be changed to detect this situation or this patch should be reverted. > > > > -------- Original Message -------- > Subject: [PHP-CVS] cvs: php-src /ext/standard formatted_print.c > Date: Sun, 03 Jun 2007 09:11:52 -0000 > From: Brian Shire > To: php-cvs@lists.php.net > > shire Sun Jun 3 09:11:52 2007 UTC > > Modified files: > /php-src/ext/standard formatted_print.c > Log: > Change printf %u behavior so that it does not truncate numbers at 32-bits. (Reported by Aditya Agarwal.) > > > http://cvs.php.net/viewvc.cgi/php-src/ext/standard/formatted_print.c?r1=1.100&r2=1.101&diff_format=u > Index: php-src/ext/standard/formatted_print.c > diff -u php-src/ext/standard/formatted_print.c:1.100 php-src/ext/standard/formatted_print.c:1.101 > --- php-src/ext/standard/formatted_print.c:1.100 Thu May 17 17:29:09 2007 > +++ php-src/ext/standard/formatted_print.c Sun Jun 3 09:11:52 2007 > @@ -16,7 +16,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: formatted_print.c,v 1.100 2007/05/17 17:29:09 tony2001 Exp $ */ > +/* $Id: formatted_print.c,v 1.101 2007/06/03 09:11:52 shire Exp $ */ > > #include /* modf() */ > #include "php.h" > @@ -278,7 +278,7 @@ > > PRINTF_DEBUG(("sprintf: appenduint(%x, %x, %x, %d, %d, '%c', %d)\n", > *buffer, pos, size, number, width, padding, alignment)); > - magn = (unsigned int) number; > + magn = (unsigned long) number; > > /* Can't right-pad 0's on integers */ > if (alignment == 0 && padding == '0') padding = ' '; > -- Wbr, Antony Dovgal