Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31640
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.190 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=JfXgM5WNFC1aIeaRucu70xamBV/v2uz29uK9498MgWQHEP2eXZdgB+NHvFv/MMh/DwtzGmsI7twkBVKtv0ZV156oTnGC37Kqu5JKJTi/PHbIl6B40bEcCOpyaBypBqxioMKRbaiDM/jqAR1sWzaCf5NewX1651BxtMH+uiL6vYM=
Message-ID: <d8269d910708161150o797babe4u16b5de6f8d98dd5c@mail.gmail.com>
Date: Thu, 16 Aug 2007 20:50:39 +0200
To: "=?ISO-8859-1?Q?Johannes_Schl=FCter?=" <johannes@php.net>
Cc: "PHP Internals List" <internals@lists.php.net>
In-Reply-To: <1187289646.3724.57.camel@johannes.nop>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <1186737992.2772.57.camel@johannes.nop>
	 <d8269d910708161127q2ad496fqe93a4f1d7844e724@mail.gmail.com>
	 <1187289646.3724.57.camel@johannes.nop>
Subject: Re: [PHP-DEV] Renaming namespaces to packages
From: tijnema@gmail.com (Tijnema)

On 8/16/07, Johannes Schl=FCter <johannes@php.net> wrote:
> Hi Tijnema,
>
> On Thu, 2007-08-16 at 20:27 +0200, Tijnema wrote:
> > On 8/10/07, Johannes Schl=FCter <johannes@php.net> wrote:
> > > Hi,
> > >
> > > I think we reached the consensus to rename namespaces to packages as =
our
> > > implementation is more package-like. Therefore I wrote the correspond=
ing
> > > patch which tries to get rid of all "namespaces" and "ns" (well, not =
all
> > > "ns" only the namespace-related ones of course) used in the code.
> > > Additionally I changed all package-tests. Any objections?
> > >
> > > Does anybody (with the move-on-CVS-server powers) care about the hist=
ory
> > > of the tests? Then please cp ZendEngine2/tests/ns_* to pkg_* there el=
se
> > > I'll do a simple cvs rm and cvs add.
> > >
> > > The patch is at
> > > http://schlueters.de/~johannes/php/zend_namespace_to_package.diff and
> > > the tarball with the changed tests at
> > > http://schlueters.de/~johannes/php/zend_package_tests.tar.bz2
> > >
> > > johannes
> > >
> >
> > Just a little note, right now, your patch doesn't seem to work
> > Johannes. It's saying that T_NAMESPACE and T_NS can't be found in
> > Zend/zend_language_scanner.c.
> >
> > Extra patch (that worked for me):
> >
> > --------zend_packages_extra_patch.patch------
> > --- Zend/zend_language_scanner.c      31 Jul 2007 23:23:37 -0000
> > +++ Zend/zend_language_scanner.c      16 Aug 2007 20:13:24 -0000
>
> If patching that file configure didn't find a proper flex version since
> that file is generated from Zend/zend_language_scanner.l using flex.
>
> johannes
>

Well, why does PHP compiles fine without the patch?, and why is this
file in the snapshot package when it is generated from flex?


I have flex 2.5.33 installed btw, that's fine right?

Tijnema
--=20
Vote for PHP Color Coding in Gmail! -> http://gpcc.tijnema.info