Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31639 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 24117 invoked by uid 1010); 16 Aug 2007 18:41:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 24093 invoked from network); 16 Aug 2007 18:41:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Aug 2007 18:41:23 -0000 Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.163 mail4.netbeat.de Received: from [83.243.58.163] ([83.243.58.163:46598] helo=mail4.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/E0-18530-A4A94C64 for ; Thu, 16 Aug 2007 14:41:19 -0400 Received: (qmail 31764 invoked by uid 507); 16 Aug 2007 18:41:00 -0000 Received: from unknown (HELO ?192.168.1.102?) (postmaster%schlueters.de@82.135.86.49) by mail4.netbeat.de with ESMTPA; 16 Aug 2007 18:41:00 -0000 To: Tijnema Cc: PHP Internals List In-Reply-To: References: <1186737992.2772.57.camel@johannes.nop> Content-Type: text/plain; charset=UTF-8 Date: Thu, 16 Aug 2007 20:40:46 +0200 Message-ID: <1187289646.3724.57.camel@johannes.nop> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-1.fc7) Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Renaming namespaces to packages From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi Tijnema, On Thu, 2007-08-16 at 20:27 +0200, Tijnema wrote: > On 8/10/07, Johannes Schlüter wrote: > > Hi, > > > > I think we reached the consensus to rename namespaces to packages as our > > implementation is more package-like. Therefore I wrote the corresponding > > patch which tries to get rid of all "namespaces" and "ns" (well, not all > > "ns" only the namespace-related ones of course) used in the code. > > Additionally I changed all package-tests. Any objections? > > > > Does anybody (with the move-on-CVS-server powers) care about the history > > of the tests? Then please cp ZendEngine2/tests/ns_* to pkg_* there else > > I'll do a simple cvs rm and cvs add. > > > > The patch is at > > http://schlueters.de/~johannes/php/zend_namespace_to_package.diff and > > the tarball with the changed tests at > > http://schlueters.de/~johannes/php/zend_package_tests.tar.bz2 > > > > johannes > > > > Just a little note, right now, your patch doesn't seem to work > Johannes. It's saying that T_NAMESPACE and T_NS can't be found in > Zend/zend_language_scanner.c. > > Extra patch (that worked for me): > > --------zend_packages_extra_patch.patch------ > --- Zend/zend_language_scanner.c 31 Jul 2007 23:23:37 -0000 > +++ Zend/zend_language_scanner.c 16 Aug 2007 20:13:24 -0000 If patching that file configure didn't find a proper flex version since that file is generated from Zend/zend_language_scanner.l using flex. johannes > @@ -5415,7 +5415,7 @@ > case 59: > YY_RULE_SETUP > { > - return T_NAMESPACE; > + return T_PACKAGE; > } > YY_BREAK > case 60: > @@ -5908,13 +5908,13 @@ > case 118: > YY_RULE_SETUP > { > - if (CG(current_namespace)) { > - *zendlval = *CG(current_namespace); > + if (CG(current_package)) { > + *zendlval = *CG(current_package); > zval_copy_ctor(zendlval); > } else { > ZVAL_EMPTY_TEXT(zendlval); > } > - return T_NS_C; > + return T_PKG_C; > } > YY_BREAK > case 119: > ---------------------------------- > > > Tijnema > -- > Vote for PHP Color Coding in Gmail! -> http://gpcc.tijnema.info >