Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31638
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.162.179 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=Gw/mGf7f/G7Mb/+pQLiSdlIzUUx9nZaXWJ/EZBLedOKxhsMZ1oZjo+I4Jv/7TDXXy5WqP1EBosH31zOIGYjuYb1btJv2HbLRDEjv6hU8y6mKxJ0tR/dGTouxT1jq7jQAYfF+Hg0bE+HkSmA8IWls8pfVtguKNiYliAyRjMks9oU=
Message-ID: <d8269d910708161127q2ad496fqe93a4f1d7844e724@mail.gmail.com>
Date: Thu, 16 Aug 2007 20:27:57 +0200
To: "=?ISO-8859-1?Q?Johannes_Schl=FCter?=" <johannes@php.net>
Cc: "PHP Internals List" <internals@lists.php.net>, 
	"Dmitry Stogov" <dmitry@zend.com>
In-Reply-To: <1186737992.2772.57.camel@johannes.nop>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <1186737992.2772.57.camel@johannes.nop>
Subject: Re: [PHP-DEV] Renaming namespaces to packages
From: tijnema@gmail.com (Tijnema)

On 8/10/07, Johannes Schl=FCter <johannes@php.net> wrote:
> Hi,
>
> I think we reached the consensus to rename namespaces to packages as our
> implementation is more package-like. Therefore I wrote the corresponding
> patch which tries to get rid of all "namespaces" and "ns" (well, not all
> "ns" only the namespace-related ones of course) used in the code.
> Additionally I changed all package-tests. Any objections?
>
> Does anybody (with the move-on-CVS-server powers) care about the history
> of the tests? Then please cp ZendEngine2/tests/ns_* to pkg_* there else
> I'll do a simple cvs rm and cvs add.
>
> The patch is at
> http://schlueters.de/~johannes/php/zend_namespace_to_package.diff and
> the tarball with the changed tests at
> http://schlueters.de/~johannes/php/zend_package_tests.tar.bz2
>
> johannes
>

Just a little note, right now, your patch doesn't seem to work
Johannes. It's saying that T_NAMESPACE and T_NS can't be found in
Zend/zend_language_scanner.c.

Extra patch (that worked for me):

--------zend_packages_extra_patch.patch------
--- Zend/zend_language_scanner.c=0931 Jul 2007 23:23:37 -0000
+++ Zend/zend_language_scanner.c=0916 Aug 2007 20:13:24 -0000
@@ -5415,7 +5415,7 @@
 case 59:
 YY_RULE_SETUP
 {
-=09return T_NAMESPACE;
+=09return T_PACKAGE;
 }
 =09YY_BREAK
 case 60:
@@ -5908,13 +5908,13 @@
 case 118:
 YY_RULE_SETUP
 {
-=09if (CG(current_namespace)) {
-=09=09*zendlval =3D *CG(current_namespace);
+=09if (CG(current_package)) {
+=09=09*zendlval =3D *CG(current_package);
 =09=09zval_copy_ctor(zendlval);
 =09} else {
 =09=09ZVAL_EMPTY_TEXT(zendlval);
 =09}
-=09return T_NS_C;
+=09return T_PKG_C;
 }
 =09YY_BREAK
 case 119:
----------------------------------


Tijnema
--=20
Vote for PHP Color Coding in Gmail! -> http://gpcc.tijnema.info