Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31476
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.171 cause and error)
Reply-To: jani.taskinen@iki.fi
To: Marcus Boerger <helly@php.net>
Cc: internals@lists.php.net, David Soria Parra <dsp@php.net>
In-Reply-To: <257742794.20070807142252@marcus-boerger.de>
References: <FF.1D.61247.4C827B64@pb1.pair.com>
	 <257742794.20070807142252@marcus-boerger.de>
Content-Type: text/plain
Date: Tue, 07 Aug 2007 17:59:56 +0300
Message-ID: <1186498796.3401.0.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support -
	part 2
From: jani.taskinen@sci.fi (Jani Taskinen)

Yes, I know about this. I was wondering about this thing long time
ago..just never got around doing anything about it.. :D

But let's wait for PHP 5.3 branch to get opened first. 

--Jani


On Tue, 2007-08-07 at 14:22 +0200, Marcus Boerger wrote:
> Hello Jani,
> 
>   David has a point here. So first of all we should move getopt
> implementation out of CLI/CGI and into main. Could you do that
> first Jani?
> 
> marcus
> 
> Monday, August 6, 2007, 3:57:26 PM, you wrote:
> 
> > Hi internals,
> 
> > so based on a discussion of php.pecl we thought about using the php_getopt
> > for the PHP_FUNCTION(getopt) instead of the system provided getopt. Here
> > is the patch for that. Hopefully someone is reviewing and commiting the
> > patch as i don't have karma. 
> 
> > It addes main/getopt.c main/php_getopt.h to the build system and uses the
> > php_getopt function in the ext/standard/basic_functions.c. Furthermore it
> > removes all HAVE_GETOPT and HARTMUT_0 switches. it also enable longopts
> > for both win and linux in the form
> >  
> > $opt = getopt("a", array("param:", "param2"));
> 
> > Where ":" in the longopts marks that the parameter takes an argument.
> 
> > The main/getopt.c and main/php_getopt.h is in fact taken from
> > sapi/cli/getopt.c and sapi/cli/php_getopt.h but is slightly modified.
> 
> > http://experimentalworks.net/~dsp/getopt.patch.tar.gz
> 
> > It also runs on windows.
> 
> > To apply the patch:
> >  1) remove 
> >        sapi/cli/getopt.c sapi/cli/php_getopt.h 
> >        sapi/cgi/getopt.c sapi/cgi/php_getopt.h
> 
> >  2) add main/getopt.c and main/php_getopt.h frm the archive
> >  3) apply the patch.
> 
> 
> 
> 
> Best regards,
>  Marcus
>