Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31475 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77547 invoked by uid 1010); 7 Aug 2007 12:23:00 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 77532 invoked from network); 7 Aug 2007 12:23:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Aug 2007 12:23:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:57143] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/01-60358-22468B64 for ; Tue, 07 Aug 2007 08:22:59 -0400 Received: from MBOERGER-ZRH (unknown [216.239.55.7]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 4E95F1B3641; Tue, 7 Aug 2007 14:22:55 +0200 (CEST) Date: Tue, 7 Aug 2007 14:22:52 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <257742794.20070807142252@marcus-boerger.de> To: Jani Taskinen CC: internals@lists.php.net, David Soria Parra In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Getopt with longopts and windows support - part 2 From: helly@php.net (Marcus Boerger) Hello Jani, David has a point here. So first of all we should move getopt implementation out of CLI/CGI and into main. Could you do that first Jani? marcus Monday, August 6, 2007, 3:57:26 PM, you wrote: > Hi internals, > so based on a discussion of php.pecl we thought about using the php_getopt > for the PHP_FUNCTION(getopt) instead of the system provided getopt. Here > is the patch for that. Hopefully someone is reviewing and commiting the > patch as i don't have karma. > It addes main/getopt.c main/php_getopt.h to the build system and uses the > php_getopt function in the ext/standard/basic_functions.c. Furthermore it > removes all HAVE_GETOPT and HARTMUT_0 switches. it also enable longopts > for both win and linux in the form > > $opt = getopt("a", array("param:", "param2")); > Where ":" in the longopts marks that the parameter takes an argument. > The main/getopt.c and main/php_getopt.h is in fact taken from > sapi/cli/getopt.c and sapi/cli/php_getopt.h but is slightly modified. > http://experimentalworks.net/~dsp/getopt.patch.tar.gz > It also runs on windows. > To apply the patch: > 1) remove > sapi/cli/getopt.c sapi/cli/php_getopt.h > sapi/cgi/getopt.c sapi/cgi/php_getopt.h > 2) add main/getopt.c and main/php_getopt.h frm the archive > 3) apply the patch. Best regards, Marcus