Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31472 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 68565 invoked by uid 1010); 7 Aug 2007 05:05:45 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 68550 invoked from network); 7 Aug 2007 05:05:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Aug 2007 05:05:45 -0000 Authentication-Results: pb1.pair.com header.from=ceo@l-i-e.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=ceo@l-i-e.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain l-i-e.com from 67.139.134.202 cause and error) X-PHP-List-Original-Sender: ceo@l-i-e.com X-Host-Fingerprint: 67.139.134.202 o2.hostbaby.com FreeBSD 4.7-5.2 (or MacOS X 10.2-10.3) (2) Received: from [67.139.134.202] ([67.139.134.202:2599] helo=o2.hostbaby.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3C/70-58486-6ADF7B64 for ; Tue, 07 Aug 2007 01:05:43 -0400 Received: (qmail 99842 invoked by uid 98); 7 Aug 2007 05:05:46 -0000 Received: from 127.0.0.1 by o2.hostbaby.com (envelope-from , uid 1013) with qmail-scanner-2.01 (clamdscan: 0.88.7/3877. Clear:RC:1(127.0.0.1):. Processed in 0.074068 secs); 07 Aug 2007 05:05:46 -0000 Received: from localhost (HELO l-i-e.com) (127.0.0.1) by localhost with SMTP; 7 Aug 2007 05:05:46 -0000 Received: from 209.254.223.2 (SquirrelMail authenticated user ceo@l-i-e.com) by www.l-i-e.com with HTTP; Tue, 7 Aug 2007 00:05:46 -0500 (CDT) Message-ID: <63403.209.254.223.2.1186463146.squirrel@www.l-i-e.com> In-Reply-To: <3514.24.12.13.192.1185780165.squirrel@www.l-i-e.com> References: <1184590056.3352.10.camel@localhost.localdomain> <3514.24.12.13.192.1185780165.squirrel@www.l-i-e.com> Date: Tue, 7 Aug 2007 00:05:46 -0500 (CDT) To: internals@lists.php.net Reply-To: ceo@l-i-e.com User-Agent: Hostbaby Webmail MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Subject: Re: [PHP-DEV] POSIX regex [PATCH] From: ceo@l-i-e.com ("Richard Lynch") On Mon, July 30, 2007 2:22 am, Richard Lynch wrote: > On Mon, July 16, 2007 7:47 am, Jani Taskinen wrote: >> Now only places using the POSIX regex functions (ext/ereg/ excluded) >> are >> ext/standard/browscap.c and ext/pgsql/pgsql.c. > > For your review, my first patch (!) along with a php test case, of > course, in a URL/directory structure that should be familiar: > > http://l-i-e.com/php5/ext/pgsql/ > > :-) > > The commit comment should probably have something not unlike this: > Use PCRE instead of POSIX regex > Remove stray closing parenthesis in PG_TIME pattern It's been a week and nobody has commented on this. Should somebody commit it now?... Or grant me commit karma to ext/pgsql CVS username is 'lynch' And, just to be sure, since it only changes internal workings and not documented features, it should go into 5.x, right?... Or is requiring PCRE instead of POSIX considered not BC for 5.x series? I'll check PHP 6 pgsql and see if it's been Unicode-ified beyond recognition for this patch, or if it applies cleanly there as well. PS I'll change the test case to do the insert with the converted data as a further check that it worked, instead of a rather bogus test insert of hand-coded data that it does now. -- Some people have a "gift" link here. Know what I want? I want you to buy a CD from some indie artist. http://cdbaby.com/browse/from/lynch Yeah, I get a buck. So?