Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:31427 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13861 invoked by uid 1010); 3 Aug 2007 14:28:59 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 13837 invoked from network); 3 Aug 2007 14:28:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Aug 2007 14:28:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=thetaphi@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=thetaphi@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 80.190.230.99 as permitted sender) X-PHP-List-Original-Sender: thetaphi@php.net X-Host-Fingerprint: 80.190.230.99 www.troja.net Linux 2.5 (sometimes 2.4) (4) Received: from [80.190.230.99] ([80.190.230.99:57969] helo=mail.troja.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C6/39-32246-7AB33B64 for ; Fri, 03 Aug 2007 10:28:57 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.troja.net (Postfix) with ESMTP id 2D0562E5E1; Fri, 3 Aug 2007 16:28:50 +0200 (CEST) Received: from mail.troja.net ([127.0.0.1]) by localhost (cyca.troja.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 11349-08; Fri, 3 Aug 2007 16:28:41 +0200 (CEST) Received: from VEGA (port-83-236-62-51.dynamic.qsc.de [83.236.62.51]) (using SSLv3 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.troja.net (Postfix) with ESMTP id 1E15E2E56D; Fri, 3 Aug 2007 16:28:41 +0200 (CEST) To: "'Ilia Alshanetsky'" , "'Uwe Schindler'" Cc: "'Antony Dovgal'" , "'PHP Internals'" References: <87E4F8AF-06DE-4FCC-AD1B-83E932A5E180@prohost.org> <000201c7d598$14f53cf0$0201a8c0@VEGA> <46B2E92A.40303@zend.com> <000001c7d5ae$1534b4f0$4cf96686@VEGA> <46B2F4D0.4070003@zend.com> <000101c7d5b6$233cf4b0$4cf96686@VEGA> <46B302AF.2060007@zend.com> <000001c7d5bb$d01eab60$4cf96686@VEGA> <46B309E5.10401@zend.com> <000401c7d5c6$71b22650$4cf96686@VEGA> <46B32A41.4000409@zend.com> <000101c7d5d2$467f1310$4cf96686@VEGA> <46B33043.2010102@zend.com> <000001c7d5d5$613b3910$4cf96686@VEGA> Date: Fri, 3 Aug 2007 16:28:44 +0200 Message-ID: <000001c7d5da$99049670$0201a8c0@VEGA> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcfV1ul3E/tsUM3fRrKI8inRby3ikAAAtyIg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3138 X-Virus-Scanned: amavisd-new at troja.net Subject: RE: [PHP-DEV] 5.2.4RC1 Released From: thetaphi@php.net ("Uwe Schindler") > On 3-Aug-07, at 9:51 AM, Uwe Schindler wrote: > > >> This's a special case and it's really great you noticed it in RC.. > >> We need a workaround for this special case, as if we make all INI > >> directives set > >> using php_admin_value non-changeable, we break the @ thing. > >> So we either need to change the @ not to use zend_alter_ini_entry, > >> or make > >> an > >> exception in that function, which I believe would be a hack. > > > > Thats correct. An idea would be to make the @ operator only change > > EG(error_reporting) without changing the whole ini-entry by > > alter_ini_entry > > (which is a big slowdown...). > > The problem with that fix that a crash would potentially leave the > error blocking on, and INI clean up will not reset it. The problem with the original fix of antony was the same: The first time any thread started to modify any INI entry it was marked as "admin"-only for the whole PHP server until a restart and it stayed in that state because the flag was changed *before* the hash table was replicated. This is a second bug. So at least the lines of antony must moved a few lines down in code... Uwe