Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:31421
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 80.190.230.99 as permitted sender)
To: "'Antony Dovgal'" <antony@zend.com>,
	"'PHP Internals'" <internals@lists.php.net>
References: <87E4F8AF-06DE-4FCC-AD1B-83E932A5E180@prohost.org> <000201c7d598$14f53cf0$0201a8c0@VEGA> <46B2E92A.40303@zend.com> <000001c7d5ae$1534b4f0$4cf96686@VEGA> <46B2F4D0.4070003@zend.com> <000101c7d5b6$233cf4b0$4cf96686@VEGA> <46B302AF.2060007@zend.com> <000001c7d5bb$d01eab60$4cf96686@VEGA> <46B309E5.10401@zend.com> <000401c7d5c6$71b22650$4cf96686@VEGA> <46B32A41.4000409@zend.com>
Date: Fri, 3 Aug 2007 15:29:09 +0200
Message-ID: <000101c7d5d2$467f1310$4cf96686@VEGA>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AcfV0EwZZ/QzBdOqQAKZojHBUW7HrQAAIqgg
In-Reply-To: <46B32A41.4000409@zend.com>
Subject: RE: [PHP-DEV] 5.2.4RC1 Released
From: thetaphi@php.net ("Uwe Schindler")

I reopened the original bug reported that lead to your change.

At the moment I am trying to fix that. I moved your code a few lines down in
zend_alter_ini_entry but until now with no success.

I suppose there is something special with error reporting that corrupts it.
It seems that it does not like it to be changed to ZEND_INI_SYSTEM because
the @operator tries to change the value (e.g. in zend_vm_execute.h), which
fails silently:

static int ZEND_BEGIN_SILENCE_SPEC_HANDLER(ZEND_OPCODE_HANDLER_ARGS)
{
	zend_op *opline = EX(opline);

	Z_LVAL(EX_T(opline->result.u.var).tmp_var) = EG(error_reporting);
	Z_TYPE(EX_T(opline->result.u.var).tmp_var) = IS_LONG;  /* shouldn't
be necessary */
	if (EX(old_error_reporting) == NULL) {
		EX(old_error_reporting) =
&EX_T(opline->result.u.var).tmp_var;
	}

	if (EG(error_reporting)) {
		zend_alter_ini_entry("error_reporting",
sizeof("error_reporting"), "0", 1, ZEND_INI_USER, ZEND_INI_STAGE_RUNTIME);
	}
	ZEND_VM_NEXT_OPCODE();
}
-----
Uwe Schindler
thetaphi@php.net - http://www.php.net
NSAPI SAPI developer
Bremen, Germany


> -----Original Message-----
> From: Antony Dovgal [mailto:antony@zend.com]
> Sent: Friday, August 03, 2007 3:15 PM
> To: Uwe Schindler
> Cc: 'Ilia Alshanetsky'; 'PHP Internals'
> Subject: Re: [PHP-DEV] 5.2.4RC1 Released
> 
> On 03.08.2007 16:04, Uwe Schindler wrote:
> > I know how this is meant. But without the added patch, it does not
> corrupt
> > error_reporting. The problem is that your patch is not compatible to a
> > webserver that runs more than one request per process (a multithreaded
> one),
> > because it modifies the ini setting in a way that affects later running
> > threads.
> 
> Ok, I see.
> Please fill a bug report and assign it to me, I'll deal with it.
> 
> --
> Wbr,
> Antony Dovgal