Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:3094
Return-Path: <george@omniti.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 35165 invoked from network); 1 Jul 2003 18:42:11 -0000
Received: from unknown (HELO longsword.omniti.com) (66.80.117.3)
  by pb1.pair.com with SMTP; 1 Jul 2003 18:42:11 -0000
Received: from ip-66-80-117-2.nyc.megapath.net ([66.80.117.2] helo=maya.local.)
	by longsword.omniti.com with asmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.14)
	id 19XQ5V-0002iu-Al; Tue, 01 Jul 2003 14:42:45 -0400
Date: Tue, 1 Jul 2003 14:44:37 -0400
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v543)
Cc: engine2@lists.zend.com,
 internals@lists.php.net
To: Timm Friebe <thekid@thekid.de>
In-Reply-To: <1057084048.43882.22.camel@localhost>
Message-ID: <111F1AF6-ABF4-11D7-B5D4-000393B2B3C0@omniti.com>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.543)
Subject: Re: [Zend Engine 2] Work on reflection API
From: george@omniti.com (George Schlossnagle)
References: <1057084048.43882.22.camel@localhost>


On Tuesday, July 1, 2003, at 02:27  PM, Timm Friebe wrote:

> - Made use of the ZEND_DO_THROW macro in the constructors (see
>   previous mail to engine2@ including a patch to zend_API.h)

I privatized this for the moment until your other patch is accepted or 
what have you.  Otherwise looks great.  Committing.
>
> - Added Reflection_Class::newInstance. This method takes a variable
>   amount of arguments and passes them to the object's constructor
>   if there is one.

I don't think this works correctly for builtin classes that need to do 
their own allocation.  I'll poke some more, or you can convince me I'm 
wrong.

Otherwise everything looks cool.