Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:30426
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.184.231 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=RpK1oIY7QdfK9hOP4+K2u4gzt7YNovTuRFyHY4VcHxG7gh7C0aRxsaGh2x8Oa5C9Xu8YRWL13EakOvHDBjIaM+XZzGxdGpgtGinR8SdoA9X+DL1N0fGjbHaKQwYUuoXLQGWOWOjcidbtPtgDBwtyxzkBEBOzzzrrp6rfuOst6lk=
Message-ID: <b5f7bf6c0707030737v408e7ff5he113f5ad6419dc1f@mail.gmail.com>
Date: Tue, 3 Jul 2007 10:37:44 -0400
Sender: david.coallier@gmail.com
To: "Sara Golemon" <pollita@php.net>
Cc: internals@lists.php.net
In-Reply-To: <4F.32.06865.30369864@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4F.32.06865.30369864@pb1.pair.com>
Subject: Re: [PHP-DEV] SimpleXML emptiness
From: davidc@php.net ("David Coallier")

On 7/2/07, Sara Golemon <pollita@php.net> wrote:
> Currently, an empty check like the following returns false because
> SimpleXML only checks for node existence in has_property.  I'd like to
> propose the attached patch to change this to look at the node's children
>   and apply PHP's emptiness rules to the content.
>
> $data = '<?xml version="1.0 ?>
> <doc>
>    <e1></e1>
>    <e2>0</e2>
>    <f1>foo</f1>
>    <x eprop="" fprop="data" />
> </doc>';
>
> $s = simplexml_load_string($data);
> var_dump(empty($s->e1)); // Currently false
> var_dump(empty($s->e2)); // Currently false
> var_dump(empty($s->f1)); // False
> var_dump(empty($s->x['eprop'])); // Currently false
> var_dump(empty($s->x['fprop'])); // False
>
> Note that this patch only effects elements which only contains an empty
> text node or only a text node with a literal "0".  If the element
> contains real children, then it's considered to be non-empty (even if
> those children are in turn empty themselves).
>
> -Sara
>
>
> Index: ext/simplexml/simplexml.c
> ===================================================================
> RCS file: /repository/php-src/ext/simplexml/simplexml.c,v
> retrieving revision 1.151.2.23
> diff -u -p -r1.151.2.23 simplexml.c
> --- ext/simplexml/simplexml.c   1 Jan 2007 09:40:27 -0000       1.151.2.23
> +++ ext/simplexml/simplexml.c   2 Jul 2007 20:30:05 -0000
> @@ -692,6 +692,11 @@ static int sxe_prop_dim_exists(zval *obj
>                                         attr = attr->next;
>                                 }
>                         }
> +                       if (exists && check_empty == 1 &&
> +                               (!attr->children || !attr->children->content || !attr->children->content[0] || !xmlStrcmp(attr->children->content, "0")) ) {
> +                               /* Attribute with no content in it's text node */
> +                               exists = 0;
> +                       }
>                 }
>
>                 if (elements) {
> @@ -714,6 +719,11 @@ static int sxe_prop_dim_exists(zval *obj
>                         }
>                         if (node) {
>                                 exists = 1;
> +                                if (check_empty == 1 &&
> +                                       (!node->children || (node->children->type == XML_TEXT_NODE && !node->children->next &&
> +                                               (!node->children->content || !node->children->content[0] || !xmlStrcmp(node->children->content, "0")))) ) {
> +                                       exists = 0;
> +                               }
>                         }
>                 }
>         }
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Tested it and makes perfect sense.

-- 
David Coallier,
Founder & Software Architect,
Agora Production (http://agoraproduction.com)
51.42.06.70.18