Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:30335
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain oceania.net designates 64.22.118.220 as permitted sender)
Date: Tue, 26 Jun 2007 11:49:40 +1000
To: internals@lists.php.net
Cc: wez@php.net
Message-ID: <20070626114940.2b6c51a0.kevin@oceania.net>
Organization: Oceania
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: pdo_mysql patch
From: kevin@oceania.net (Kevin Waterson)

currently pdo_mysql is unable to discern between a BLOB and a TEXT field
in mysql_statement.c
By using the current  if (IS_BLOB(F->flags)), which is now deprecated in
the mysql c api, it will be true for both TEXT and BLOB fields.

By updating a little to the newer api and checking with F->type we get
the same result, however, further checking on the character set number
can distinguish between BINARY and CHAR, VARBINARY and VARCHAR, and BLOB
and TEXT fields.

When using PDOStatement::getColumnMeta() any field with charsetnr of 63
reports as text, rather than blob. Patch follows...

--- old.c       2007-06-26 11:27:57.000000000 +1000
+++ mysql_statement.c   2007-06-26 11:26:47.000000000 +1000
@@ -581,8 +581,12 @@
        if (F->flags & UNIQUE_KEY_FLAG) {
                add_next_index_string(flags, "unique_key", 1);
        }
-       if (IS_BLOB(F->flags)) {
-               add_next_index_string(flags, "blob", 1);
+       if(F->type == MYSQL_TYPE_BLOB)  {
+               if(F->charsetnr == 63) {
+                       add_next_index_string(flags, "blob", 1);
+               } else {
+                       add_next_index_string(flags, "text", 1);
+               }
        }
        str = type_to_name_native(F->type);
        if (str) {




-- 
"Democracy is two wolves and a lamb voting on what to have for lunch. 
Liberty is a well-armed lamb contesting the vote."