Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:30244 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 66707 invoked by uid 1010); 19 Jun 2007 08:44:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 66692 invoked from network); 19 Jun 2007 08:44:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2007 08:44:17 -0000 Authentication-Results: pb1.pair.com header.from=gwynne@wanderingknights.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=gwynne@wanderingknights.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain wanderingknights.org from 208.97.132.177 cause and error) X-PHP-List-Original-Sender: gwynne@wanderingknights.org X-Host-Fingerprint: 208.97.132.177 sd-green-bigip-177.dreamhost.com Linux 2.4/2.6 Received: from [208.97.132.177] ([208.97.132.177:38989] helo=postalmail-a4.g.dreamhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3E/73-39378-E5797764 for ; Tue, 19 Jun 2007 04:44:15 -0400 Received: from [192.168.2.197] (c-24-61-79-221.hsd1.ma.comcast.net [24.61.79.221]) by postalmail-a4.g.dreamhost.com (Postfix) with ESMTP id E3DDE11F8AC; Tue, 19 Jun 2007 01:44:10 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <10845a340706190138u65c868ccifcd8db7d8fb726cb@mail.gmail.com> References: <00.05.25319.F9955764@pb1.pair.com> <14.EA.00919.65307764@pb1.pair.com> <1182239257.3364.890.camel@johannes.nop> <10845a340706190138u65c868ccifcd8db7d8fb726cb@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-ID: Content-Transfer-Encoding: 7bit Date: Tue, 19 Jun 2007 04:44:06 -0400 To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= , muquaddim , php-dev List , RQuadling@GoogleMail.com X-Mailer: Apple Mail (2.752.3) Subject: Re: [PHP-DEV] Re: documentation of php5ts.dll and .NET wrapper From: gwynne@wanderingknights.org (Gwynne Raskind) On Jun 19, 2007, at 4:38 AM, Richard Quadling wrote: >> Sara has a nice article about TSRM: >> http://blog.libssh2.org/index.php?/archives/22-What-the-heck-is- >> TSRMLS_CC-anyway.html and since you're using php5ts.dll you have >> zts enabled. > Why have ... > > TSRMLS_CC > > when ... > > , TSRMLS_C > > actually looks more "correct" when you're reading the code ... > > php_myextension_globals_ctor(&myextension_globals TSRMLS_CC); > > vs > > php_myextension_globals_ctor(&myextension_globals , TSRMLS_C); > > > I'm not saying change anything, but from someone trying to make > headway with the source, it just looks right (parameters are separated > by a comma not a space). Because with ZTS off, this would result in: php_myextension_globals_ctor(&myextension_globals, ); Which would be a syntax error. -- Gwynne, Daughter of the Code "This whole world is an asylum for the incurable."