Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:30243 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65235 invoked by uid 1010); 19 Jun 2007 08:42:41 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 65219 invoked from network); 19 Jun 2007 08:42:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Jun 2007 08:42:41 -0000 Authentication-Results: pb1.pair.com header.from=stuttle@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=stuttle@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.169 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: stuttle@gmail.com X-Host-Fingerprint: 66.249.92.169 ug-out-1314.google.com Linux 2.4/2.6 Received: from [66.249.92.169] ([66.249.92.169:24746] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8B/33-39378-EF697764 for ; Tue, 19 Jun 2007 04:42:40 -0400 Received: by ug-out-1314.google.com with SMTP id m2so59319uge for ; Tue, 19 Jun 2007 01:42:36 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=OzVDYMRc3ose7Z+6Uvh4ZO0GkHKS78dxzU+NAtPO86QV2qpp+EcOAHkgDca9Ahi1TrOxtHrJEBhSsniuE14k4gDNAvUwh596xe6IfdbC/QeyzN59D1G3623wugRqq0ayW85lcwRkZX3Y0Q5MfrcHKEMHbTUjTlf/JLg3++5Qn80= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=gmEi/7g75mcrpCTxgvkOfgdsRz1AYR/mPlCQu2cHtMdWcX0nPzIlF2ZbZ0d+pgLWslpcjziHezNh+T9WtlKtP3wZIHtuoQzHvpoLkSMv7jeyTye4bDCkqiII08jDVEGe5311wJ6Egc40tQodZEEP+AExB2oZ8hEsV0bAtVjb5QU= Received: by 10.67.98.9 with SMTP id a9mr326134ugm.1182242553597; Tue, 19 Jun 2007 01:42:33 -0700 (PDT) Received: from ?192.168.0.128? ( [81.174.253.131]) by mx.google.com with ESMTP id m1sm935265uge.2007.06.19.01.42.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 19 Jun 2007 01:42:33 -0700 (PDT) Message-ID: <467796EF.4040005@gmail.com> Date: Tue, 19 Jun 2007 09:42:23 +0100 User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: RQuadling@GoogleMail.com CC: =?UTF-8?B?Sm9oYW5uZXMgU2NobMO8dGVy?= , muquaddim , internals@lists.php.net References: <00.05.25319.F9955764@pb1.pair.com> <14.EA.00919.65307764@pb1.pair.com> <1182239257.3364.890.camel@johannes.nop> <10845a340706190138u65c868ccifcd8db7d8fb726cb@mail.gmail.com> In-Reply-To: <10845a340706190138u65c868ccifcd8db7d8fb726cb@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Re: documentation of php5ts.dll and .NET wrapper From: stuttle@gmail.com (Stut) Richard Quadling wrote: > On 19/06/07, Johannes Schlüter wrote: >> Sara has a nice article about TSRM: >> http://blog.libssh2.org/index.php?/archives/22-What-the-heck-is-TSRMLS_CC-anyway.html >> and since you're using php5ts.dll you have zts enabled. > > Why have ... > > TSRMLS_CC > > when ... > > , TSRMLS_C > > actually looks more "correct" when you're reading the code ... > > php_myextension_globals_ctor(&myextension_globals TSRMLS_CC); > > vs > > php_myextension_globals_ctor(&myextension_globals , TSRMLS_C); > > > I'm not saying change anything, but from someone trying to make > headway with the source, it just looks right (parameters are separated > by a comma not a space). Because those macros may be defined as empty, meaning you'd be trying to compile... php_myextension_globals_ctor(&myextension_globals , ); ...which the compiler is not gonna like at all. -Stut -- http://stut.net/