Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:30114
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <4666A2A4.2070305@zend.com>
Date: Wed, 06 Jun 2007 16:03:48 +0400
User-Agent: Thunderbird 2.0.0.0 (X11/20070326)
MIME-Version: 1.0
To: "mark@cyanox.nl" <mark@cyanox.nl>
CC: php-dev <internals@lists.php.net>
References: <4665D15F.2040501@cyanox.nl> <4665D357.5070509@zend.com> <4665E1BF.5090107@cyanox.nl> <46664FBC.5070102@zend.com> <46665D62.7090009@cyanox.nl>
In-Reply-To: <46665D62.7090009@cyanox.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Recursive classes ... possible bug?
From: antony@zend.com (Antony Dovgal)

On 06.06.2007 11:08, mark@cyanox.nl wrote:
>> Why?
>> The behavior is quite clear - if the objects are instances of the same 
>> class, we have no other way to compare them but to compare their 
>> properties, this also applies to properties' properties and 
>> properties' properties' properties etc.
> Well yes but in this case they are the same instance. Comparing the 
> properties is then useless since they will always be the same.
>
> Well there could be made a check to see if the objects are the same 
> instance (like with ===) before actually checking the properties.

Hm.. I was actually a bit surprised to see that we don't do "===" before doing "==" on objects.
That would of course prevent the recursion in case of comparing an object to itself.

I committed a patch minute ago, but it obviously won't change the case when the objects are 
different and contain circular references. 

Anyway, thanks a lot for pointing this out.

-- 
Wbr, 
Antony Dovgal