Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:30053
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <46651C40.2010109@zend.com>
Date: Tue, 05 Jun 2007 12:18:08 +0400
User-Agent: Thunderbird 2.0.0.0 (X11/20070326)
MIME-Version: 1.0
To: Sebastian Bergmann <sb@sebastian-bergmann.de>
CC:  internals@lists.php.net
References: <es10qs$8f4$1@sea.gmane.org> <4664304D.5010609@zend.com> <f4335d$rbr$1@sea.gmane.org>
In-Reply-To: <f4335d$rbr$1@sea.gmane.org>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV]  Benchmark Suite
From: antony@zend.com (Antony Dovgal)

On 05.06.2007 11:25, Sebastian Bergmann wrote:
> Antony Dovgal wrote:
>> Hello Sebastian.
> 
>  Hello Antony,
> 
>> What's the status of this?
>> Do you have anything working?
> 
>  back in February/March when I first posted about this, I discussed this
>  with Marcus. The conclusion was that we wanted to rewrite run-tests.php
>  based on the Iterator approach I used for the benchmark system's
>  prototype. 

Require SPL for a test suite?
Doesn't seem to be good idea..

> Benchmarks would then be .phpb in addition to .phpt for
>  tests.
> 
>  I did some work on this but stopped when I got negative feedback (on
>  IRC) towards the idea of rewriting "something that works"
>  (run-tests.php).

Well, I personally think we'll have to do it sooner or later. 
The current version run-tests.php is really hard to maintain and improve.

We can have both for some time and drop the old one when we're sure that the new one is stable.
It's a developers tool anyway..
 
>  I see several options to continue:
> 
>    - Add .phpb style support for benchmarks to the current run-tests.php.
> 
>    - Improve run-tests.php to also collect Peak Memory Usage, store the
>      data in SQLite, and have a test (optionally) fail when it takes more
>      memory than it did in the past (one of the ideas that I had for the
>      rewrite).

Oh, that would be too much IMO..

>    - Do the rewrite.
> 
>  Opinions?

I'm for the rewrite and I'm ready to help.

-- 
Wbr, 
Antony Dovgal