Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29967 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 82870 invoked by uid 1010); 30 May 2007 20:50:03 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 82853 invoked from network); 30 May 2007 20:50:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 May 2007 20:50:03 -0000 Authentication-Results: pb1.pair.com header.from=colder@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=colder@php.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain php.net from 213.239.212.54 cause and error) X-PHP-List-Original-Sender: colder@php.net X-Host-Fingerprint: 213.239.212.54 dns1.omne-serveurs.net Linux 2.4/2.6 Received: from [213.239.212.54] ([213.239.212.54:50608] helo=dns1.omne-serveurs.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/20-16032-673ED564 for ; Wed, 30 May 2007 16:50:02 -0400 Received: (qmail 31448 invoked from network); 30 May 2007 20:49:50 -0000 Received: from 80.218.249.160 by dns1 (envelope-from , uid 1004) with qmail-scanner-1.23 (clamdscan: 0.82. spamassassin: 3.0.1. perlscan: 1.32. Clear:RC:1(80.218.249.160):. Processed in 0.028683 secs); 30 May 2007 20:49:50 -0000 Received: from 80-218-249-160.dclient.hispeed.ch (HELO ?10.0.0.1?) (80.218.249.160) by dns1.omne-serveurs.net with (DHE-RSA-AES256-SHA encrypted) SMTP; 30 May 2007 20:49:50 -0000 Message-ID: <465DE36E.7080503@php.net> Date: Wed, 30 May 2007 22:49:50 +0200 User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: Stanislav Malyshev CC: internals@lists.php.net References: <465D8C6B.2000809@php.net> <465DB3A9.6010707@zend.com> <465DBAC6.5080700@php.net> <465DBEFE.4060907@zend.com> In-Reply-To: <465DBEFE.4060907@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [patch] Callbacks bug/change request From: colder@php.net (Etienne Kneuss) Stanislav Malyshev wrote: >> EG(scope) is used by zend_u_fetch_class to get the parent/current >> class, I'm only altering it temporarily before zend_u_fetch_class and >> restore it after that, no harm done. > > I was speaking about 5.2 patch, didn't check the HEAD one. Oh, I see now what you mean. I ported the patch to 5_2 with the assumption that zend_lookup_class also used EG(scope), but in fact it doesn't. I updated the patch[1] which now directly uses calling_scope/ce_org instead of the current scope for parent/self resolution. I hope this one better fits your requirements. Regards 1: http://patches.colder.ch/Zend/callbacks_5_2.patch?markup -- Etienne Kneuss http://www.colder.ch colder@php.net Men never do evil so completely and cheerfully as when they do it from a religious conviction. -- Pascal