Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29939
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Tue, 29 May 2007 23:22:31 -0700
Message-ID: <698DE66518E7CA45812BD18E807866CE3AFFB9@us-ex1.zend.net>
Thread-Topic: [PHP-DEV] TSRM changes broke windows compile
Thread-Index: AcehOvaQ2RbKYZUhRyy+SQ8kd8U7EwBRvgtA
References: <4657170E.8060701@zend.com> <46571CCC.4030801@zend.com> <46573710.6070800@lerdorf.com> <46573903.2060204@zend.com> <000001c79f12$9b6650b0$0201a8c0@VEGA> <465756D4.1080604@lerdorf.com> <000001c79f19$05a337d0$0201a8c0@VEGA> <46576108.6070300@lerdorf.com> <000101c79f1c$8499ef90$0201a8c0@VEGA> <46576557.2040902@lerdorf.com> <46576BFD.1050606@lerdorf.com> <46578810.3000007@zend.com> <alpine.DEB.0.98.0705281714030.30065@kossu.ez.no>
To: "Derick Rethans" <derick@php.net>,
	"Stas Malyshev" <stas@zend.com>
Cc: "Rasmus Lerdorf" <rasmus@lerdorf.com>,
	"Uwe Schindler" <thetaphi@php.net>,
	"PHP Internals" <internals@lists.php.net>
Subject: RE: [PHP-DEV] TSRM changes broke windows compile
From: andi@zend.com ("Andi Gutmans")

Actually my experience with optimizations is that 2+2 !=3D 4, but that's
besides the point. And it also depends on a lot of other factors.
Benchmarks are not easy as they are dependent on many factors.

But in any case, we worked hard from day 1 to really componentize TSRM,
Zend and somewhat SAPI so that we get a much more maintainable code base
with less dependencies. As it is, the PHP code base is becoming more
complex and harder to maintain so we need to try our best to keep good
interfaces and separations when possible. Also the ability to reuse
these components in other projects although not very common has happened
and is an additional benefit to the better design.

Thanks Rasmus for reverting for now. I think it's best to keep things
as-is but if that really isn't an option (or a local yahoo! patch isn't)
then we can think of ways to keep the strict interface but make this
work. For example by passing a callback via tsrm_startup(}.

Andi=20

> -----Original Message-----
> From: Derick Rethans [mailto:derick@php.net]=20
> Sent: Monday, May 28, 2007 8:14 AM
> To: Stas Malyshev
> Cc: Rasmus Lerdorf; Uwe Schindler; 'PHP Internals'
> Subject: Re: [PHP-DEV] TSRM changes broke windows compile
>=20
> On Fri, 25 May 2007, Stanislav Malyshev wrote:
>=20
> > It's great to have a benchmark, thanks!
> >=20
> > > The standard of deviation was rather high though.  Over=20
> 10 runs on=20
> > > each the averages were:
> > >=20
> > > time: 646 req/sec
> > > sapi: 659 req/sec
> >=20
> > So it's 2%, not that big a deal...
>=20
> I think it is... as all the little bits add up to make things quicker.
>=20
> regards,
> Derick
>=20
> --
> PHP Internals - PHP Runtime Development Mailing List To=20
> unsubscribe, visit: http://www.php.net/unsub.php
>=20
>=20