Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29788 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37107 invoked by uid 1010); 26 May 2007 01:03:21 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 37092 invoked from network); 26 May 2007 01:03:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 May 2007 01:03:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.114 unknown Windows 2000 SP4, XP SP1 Received: from [63.205.162.114] ([63.205.162.114:21842] helo=us-ex1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 76/35-23498-75787564 for ; Fri, 25 May 2007 21:03:21 -0400 Received: from [127.0.0.1] ([192.168.16.180]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 25 May 2007 18:03:17 -0700 Message-ID: <46578754.30408@zend.com> Date: Fri, 25 May 2007 18:03:16 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Rasmus Lerdorf CC: Uwe Schindler , 'PHP Internals' References: <4657170E.8060701@zend.com> <46571CCC.4030801@zend.com> <46573710.6070800@lerdorf.com> <46573903.2060204@zend.com> <000001c79f12$9b6650b0$0201a8c0@VEGA> <465756D4.1080604@lerdorf.com> <46575C57.6010909@zend.com> <46575FD9.8080405@lerdorf.com> In-Reply-To: <46575FD9.8080405@lerdorf.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 May 2007 01:03:17.0370 (UTC) FILETIME=[A4FE6DA0:01C79F31] Subject: Re: [PHP-DEV] TSRM changes broke windows compile From: stas@zend.com (Stanislav Malyshev) > Well, by that logic you would be fine with: > > #define TIME_CALL sapi_get_request_time(TSRMLS_C) > > and in tsrm_virtual_cwd.c > > #ifndef TIME_CALL > define TIME_CALL time(0) > #endif > ... > t = CWDG(realpath_cache_ttl)?TIME_CALL:0; Theoretically yes, that could work, but: > > that makes it environment-dependent instead of explicitly-dependent, and > also way harder to debug. > > Environmental side-effects like that are nasty. Exactly. So I'd propose to think how to do it right - not excluding taking the whole cache & system-dependant filesystem things out of TSRM. They do not really related to the rest of TSRM and could be abstracted same way as open/output/error functions are abstracted. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/