Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29780
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 80.190.230.99 cause and error)
To: "'Rasmus Lerdorf'" <rasmus@lerdorf.com>
Cc: "'Stanislav Malyshev'" <stas@zend.com>,
	"'PHP Internals'" <internals@lists.php.net>
References: <4657170E.8060701@zend.com> <46571CCC.4030801@zend.com> <46573710.6070800@lerdorf.com> <46573903.2060204@zend.com> <000001c79f12$9b6650b0$0201a8c0@VEGA> <465756D4.1080604@lerdorf.com> <000001c79f19$05a337d0$0201a8c0@VEGA> <46576108.6070300@lerdorf.com>
Date: Sat, 26 May 2007 00:32:02 +0200
Message-ID: <000101c79f1c$8499ef90$0201a8c0@VEGA>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
In-Reply-To: <46576108.6070300@lerdorf.com>
Thread-Index: AcefGufIgI2Y0b4yQ0+MB23tY5gC0QAAZeNg
Subject: RE: [PHP-DEV] TSRM changes broke windows compile
From: thetaphi@php.net ("Uwe Schindler")

Hi Rasmus,

> > This is no longer the case. E.g. when compiling the module for the NSAPI
> > webserver (Sun Java System Webserver) there should be a global define
> like
> > -DNSAPI in the makefiles (not only for nsapi.c) which is not. Because of
> > that all SAPIs do not have an effect on the thread implementation. When
> > compiling PHP with ZTS you always get an .o file that links to pthreads.
> > This must be the case, because without that it would not be possible to
> link
> > a CLI PHP in parallel to the webserver specific SAPI.
> 
> That's simply not the case.  Look at the nsapi code:
> 
> #define NSAPI 1
> 
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif
> 
> #include "php.h"
> #include "php_variables.h"
> #include "ext/standard/info.h"
> #include "php_ini.h"
> #include "php_globals.h"
> #include "SAPI.h"
> #include "php_main.h"
> #include "php_version.h"
> #include "TSRM.h"
> #include "ext/standard/php_standard.h"
> #include <sys/types.h>
> #include <sys/stat.h>
> 
> It defines NSAPI before including TSRM.h and in TSRM.h we have:
> 
> #elif defined(NSAPI)
> # define THREAD_T SYS_THREAD
> # define MUTEX_T CRITICAL

Butt his is only for nsapi.c. All other PHP modules and the core itself do
not know anything about NSAPI. This leads to the fact that if the webservers
thread implementation is incompatible to the system default the build .o of
nsapi.c is not compatible to the other .o files.

This happens here:
When compiling TSRM.c with the lines in it:

TSRM_API THREAD_T tsrm_thread_id(void)
{
#ifdef TSRM_WIN32
	return GetCurrentThreadId();
#elif defined(GNUPTH)
	return pth_self();
#elif defined(PTHREADS)
	return pthread_self();
#elif defined(NSAPI)
	return systhread_current();
#elif defined(PI3WEB)
	return PIThread_getCurrent();
#elif defined(TSRM_ST)
	return st_thread_self();
#elif defined(BETHREADS)
	return find_thread(NULL);
#endif
}

NSAPI is *not* defined. This is not a problem because the
systhread_current()-NSAPI function internally calls pthread_self() but only
if the webserver runs in pthreads.
On AIX (or was it HP-UX??? I should look into my bug reports) the webserver
runs in another thread implementation. This leads to crashes in the
webserver because PHP uses pthreads (because of TSRM.c) and all the
webserver another one. In the worst case
	#define THREAD_T SYS_THREAD
is also incompatible in size and structure and misbehaves between SAPI code
(with define) and PHP (without define).

Uwe