Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29766 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12888 invoked by uid 1010); 25 May 2007 19:29:12 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 12873 invoked from network); 25 May 2007 19:29:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 May 2007 19:29:12 -0000 Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.114 unknown Windows 2000 SP4, XP SP1 Received: from [63.205.162.114] ([63.205.162.114:49165] helo=us-ex1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EB/B7-46302-60937564 for ; Fri, 25 May 2007 15:29:12 -0400 Received: from [127.0.0.1] ([192.168.16.180]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 25 May 2007 12:29:07 -0700 Message-ID: <46573903.2060204@zend.com> Date: Fri, 25 May 2007 12:29:07 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Rasmus Lerdorf CC: 'PHP Internals' References: <4657170E.8060701@zend.com> <46571CCC.4030801@zend.com> <46573710.6070800@lerdorf.com> In-Reply-To: <46573710.6070800@lerdorf.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 25 May 2007 19:29:07.0766 (UTC) FILETIME=[F67FA560:01C79F02] Subject: Re: [PHP-DEV] TSRM changes broke windows compile From: stas@zend.com (Stanislav Malyshev) > An extra syscall on every file open isn't exactly miniscule. It's a syscall not related to any filesystem or I/O so it can't be that bad. And we managed to live with it so far. > Edin also just built Windows binaries without problems. Why did it work > for him? I have no idea. But it is obvious that it doesn't work in all environments, and it worked before just fine. Anyway, both breaking build _and_ intoducing dependency of TSRM on PHP and both in a minor version _and_ both without discussing it doesn't look like very good idea to me. I would propose: 1. Revert it for 5.2.3 2. Discuss if we want TSRM/Zend be now usable only with PHP 3. Discuss if we really need this patch and if so can we do it without breaking (2) -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/