Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29762
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender)
Message-ID: <46571CCC.4030801@zend.com>
Date: Fri, 25 May 2007 10:28:44 -0700
Organization: Zend Technologies
User-Agent: Thunderbird 2.0.0.0 (Windows/20070326)
MIME-Version: 1.0
To: 'PHP Internals' <internals@lists.php.net>
References: <4657170E.8060701@zend.com>
In-Reply-To: <4657170E.8060701@zend.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] TSRM changes broke windows compile
From: stas@zend.com (Stanislav Malyshev)

I tried removing recently added include to SAPI.h and it compiles just 
fine now. In general, I think linking TSRM to SAPI is not a good idea. 
It means, among other things, that TSRM can never be used in a context 
that not links it to PHP. This is something that wasn't before and I 
don't think that introducing such change in a minore bugfix version 
worth it, yet more - for a miniscule performance optimization.

Stanislav Malyshev wrote:
> Recent TSRM changes seem to break the windows compilation for me. I'm 
> getting:
> 
> tsrm_virtual_cwd.c
> C:\Program Files\Microsoft Visual Studio 
> 8\VC\PlatformSDK\include\winsock2.h(112
> ) : error C2011: 'fd_set' : 'struct' type redefinition
>         C:\Program Files\Microsoft Visual Studio 
> 8\VC\PlatformSDK\include\winsoc
> k.h(54) : see declaration of 'fd_set'
> C:\Program Files\Microsoft Visual Studio 
> 8\VC\PlatformSDK\include\winsock2.h(147
> ) : warning C4005: 'FD_SET' : macro redefinition
> 
> and so on many times. PHP compiled just fine for a long time with the 
> same setup for me, broke just very recently. Any ideas what happened?
> 

-- 
Stanislav Malyshev, Zend Products Engineer
stas@zend.com  http://www.zend.com/