Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29745
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <4656A5BF.4020107@lerdorf.com>
Date: Fri, 25 May 2007 02:00:47 -0700
User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326)
MIME-Version: 1.0
To: Uwe Schindler <thetaphi@php.net>
CC: "'php-dev List'" <internals@lists.php.net>
References: <509DFE15-F28E-4869-A124-58E6226205A4@prohost.org> <46565A6A.8060504@krug.dk> <000001c79e9f$16441de0$0201a8c0@VEGA> <46569490.3090608@lerdorf.com> <46569577.3000801@lerdorf.com> <000001c79ea3$76c70200$0201a8c0@VEGA> <46569BD3.10306@lerdorf.com> <46569EEE.3040700@lerdorf.com> <000001c79ea8$c9e87ea0$4cf96686@VEGA>
In-Reply-To: <000001c79ea8$c9e87ea0$4cf96686@VEGA>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PHP 5.2.3RC1 Released
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Uwe Schindler wrote:
>> Rasmus Lerdorf wrote:
>>> Uwe Schindler wrote:
>>>> Does not link:
>>>>
>>>> Undefined                       first referenced
>>>>  symbol                             in file
>>>> php_during_module_startup           main/.libs/SAPI.o
>>>> php_during_module_shutdown          main/.libs/SAPI.o
>>>> ld: fatal: Symbol referencing errors. No output written to sapi/cli/php
>>>> collect2: ld returned 1 exit status
>>>> gmake: *** [sapi/cli/php] Error 1
>>> gah!  Who the heck added access functions for the static module globals
>>> in main.c that are static themselves?  That makes no sense.
>>>
>>> static int module_startup = 1;
>>> static int module_shutdown = 0;
>>> ...
>>> static int php_during_module_startup()
>>> static int php_during_module_shutdown()
>>>
>>> I had just assumed they were PHP_API functions.
>> Ok, a better approach checking SG(server_context) instead attached.  Try
>> that.
> 
> Works now. No more SEGFAULT. This solution is not the best one, but this was
> my first idea to fix this, too. It should fix it in other SAPIs, too. Apache
> for example also uses SG(server_context).

All the sapis define server_context during a request, so I think this
solution is ok.  Some of the sapis don't use it for anything, but if you
look at those like caudium and roxen you will see they do:

SG(server_context) = (void *)1; /* avoid server_context == NULL */

In the request startup code.  Other parts of PHP rely on server_context
being there.

-Rasmus