Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29743
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.162.227 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=XLhZ4IboFb1hbkBrrc+DLnyVIRDkImXYkmbq13cwVBeuGo4u0+XF6+2Gd4h6Fp1aJJEtXxtcoJ3RFIMH8MDIHnmunSrWYL0+8y4Kj3P4Npe7627wILNg78Ja2oOd0Nu8qX8bZEF9A1ioAQHm4UzIBejsubQlC3vR0IPBMqu53p4=
Message-ID: <717e56840705250141n86c2d04t212b81159e207de8@mail.gmail.com>
Date: Fri, 25 May 2007 10:41:05 +0200
Sender: martin.majlis@gmail.com
To: internals@lists.php.net
In-Reply-To: <717e56840705241650p3210b76do1e1a0ae28e7aad3d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <717e56840705241650p3210b76do1e1a0ae28e7aad3d@mail.gmail.com>
Subject: Re: [PATCH] JSON_parser
From: martin@m-core.net ("Martin Majlis")

I make some small test.
http://martin.m-core.net/misc/php/dehex.c - source code

cc dehex.c; for i in `seq 1 1000`; do ./a.out >> dehex.log; done
http://martin.m-core.net/misc/php/dehex.log - results

I ignore values greater than 4e9. And here is summary:
http://martin.m-core.net/misc/php/dehex.php

Source of PHP script: http://martin.m-core.net/misc/php/dehex.phps

So, m1 is very slow, but other ones are faster.

Martin Majlis

On 25/05/07, Martin Majlis <martin.majlis@gmail.com> wrote:
> Just small refactoring. Replacing self-made function with functions
> from standard headers.
>
> Index: JSON_parser.c
> ===================================================================
> RCS file: /repository/php-src/ext/json/JSON_parser.c,v
> retrieving revision 1.1.2.8
> diff -u -u -r1.1.2.8 JSON_parser.c
> --- JSON_parser.c       24 May 2007 22:37:59 -0000      1.1.2.8
> +++ JSON_parser.c       24 May 2007 23:41:11 -0000
> @@ -29,6 +29,8 @@
>
>  #include "JSON_parser.h"
>  #include <stdio.h>
> +#include <math.h>
> +#include <ctype.h>
>
>  #define true  1
>  #define false 0
> @@ -259,18 +261,10 @@
>
>  static int dehexchar(char c)
>  {
> -    if (c >= '0' && c <= '9')
> -    {
> -        return c - '0';
> -    }
> -    else if (c >= 'A' && c <= 'F')
> -    {
> -        return c - ('A' - 10);
> -    }
> -    else if (c >= 'a' && c <= 'f')
> -    {
> -        return c - ('a' - 10);
> -    }
> +    if (isxdigit(c))
> +    {
> +        return strtol(&c, NULL, 16);
> +    }
>      else
>      {
>          return -1;
>