Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29740
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 80.190.230.99 cause and error)
To: "'Rasmus Lerdorf'" <rasmus@lerdorf.com>,
	"'Uwe Schindler'" <thetaphi@php.net>
Cc: "'php-dev List'" <internals@lists.php.net>
References: <509DFE15-F28E-4869-A124-58E6226205A4@prohost.org> <46565A6A.8060504@krug.dk> <000001c79e9f$16441de0$0201a8c0@VEGA> <46569490.3090608@lerdorf.com> <46569577.3000801@lerdorf.com>
Date: Fri, 25 May 2007 10:05:29 +0200
Message-ID: <000001c79ea3$76c70200$0201a8c0@VEGA>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AceeoZWXj5Q9GZUYR6SbPtA97J4HZgAAdKAQ
In-Reply-To: <46569577.3000801@lerdorf.com>
Subject: RE: [PHP-DEV] PHP 5.2.3RC1 Released
From: thetaphi@php.net ("Uwe Schindler")

Does not link:

Undefined                       first referenced
 symbol                             in file
php_during_module_startup           main/.libs/SAPI.o
php_during_module_shutdown          main/.libs/SAPI.o
ld: fatal: Symbol referencing errors. No output written to sapi/cli/php
collect2: ld returned 1 exit status
gmake: *** [sapi/cli/php] Error 1

-----
Uwe Schindler
thetaphi@php.net - http://www.php.net
NSAPI SAPI developer
Bremen, Germany

> -----Original Message-----
> From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
> Sent: Friday, May 25, 2007 9:51 AM
> To: Uwe Schindler
> Cc: 'php-dev List'
> Subject: Re: [PHP-DEV] PHP 5.2.3RC1 Released
> 
> Rasmus Lerdorf wrote:
> > Uwe Schindler wrote:
> >> I tried PHP 5.2.3RC1 today and the SunONE webserver using the NSAPI
> plugin
> >> crashed in module startups with a segfault.
> >>
> >> This happens because rasmus changed tsrm_virtual_cwd.c to use
> >> get_request_time instead of time() (see changelog of that file). During
> >> module startup the extension browscap tries to open the browscap.ini
> file
> >> and uses the TSRM functions to do that (because TSRM is used in NSAPI).
> At
> >> module startup there is unfortunately no request running so the call to
> the
> >> SAPI routine sapi_nsapi_get_request_time() core dumps because of a
> missing
> >> server_context.
> >>
> >> I think that should be fixed because it affects all multithreaded
> webserver
> >> SAPIs that supply a get_request_time-function.
> >
> > Could you try the attached patch please.
> 
> It should be a time(0) call there in the ternary, of course.  Fixed
> patch attached.
> 
> -Rasmus