Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29648 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 34616 invoked by uid 1010); 21 May 2007 22:14:35 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 34601 invoked from network); 21 May 2007 22:14:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 May 2007 22:14:35 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.114 unknown Windows 2000 SP4, XP SP1 Received: from [63.205.162.114] ([63.205.162.114:55626] helo=us-ex1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FF/56-19484-8C912564 for ; Mon, 21 May 2007 18:14:35 -0400 Received: from [127.0.0.1] ([192.168.16.109]) by us-ex1.zend.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 21 May 2007 15:14:29 -0700 Message-ID: <465219C0.8080106@zend.com> Date: Mon, 21 May 2007 15:14:24 -0700 Organization: Zend Technologies User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Cristian Rodriguez CC: internals@lists.php.net References: <465022BE.1020905@hardened-php.net> <7d5a202f0705201415s71982fd2jb61b8bffbb7ba6de@mail.gmail.com> <465211A1.6010908@zend.com> In-Reply-To: <465211A1.6010908@zend.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 May 2007 22:14:29.0504 (UTC) FILETIME=[66A9B800:01C79BF5] Subject: Re: [PHP-DEV] fixing refcount overflow in PHP 4 From: stas@zend.com (Stanislav Malyshev) > thing is that I don't see macros ZVAL_SAFE_REF_ADD and ZVAL_SAFE_REF_SET > used anywhere, so probably there's no need for them. My bad - they are used of course, I just looked into the wrong place. I would however rename ZVAL_SAFE_REF to something like ZVAL_SAFE_ADDREF. Also, comparing values to 0xffff might be not effective if they are ushort... -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/