Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29600
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain hardened-php.net from 81.169.159.221 cause and error)
Message-ID: <46513E93.5000902@hardened-php.net>
Date: Mon, 21 May 2007 08:39:15 +0200
User-Agent: Thunderbird 2.0.0.0 (Windows/20070326)
MIME-Version: 1.0
To: David <planetbeing@gmail.com>
Cc: 'Stanislav Malyshev' <stas@zend.com>, internals@lists.php.net
References: <465022BE.1020905@hardened-php.net>	 <7d5a202f0705201415s71982fd2jb61b8bffbb7ba6de@mail.gmail.com>	 <46513546.5000303@zend.com> <7d5a202f0705202303s2ff4d0cdg1157c1e245c3c2e4@mail.gmail.com> <46513745.7030701@zend.com> <000001c79b71$543e0970$fcba1c50$@com>
In-Reply-To: <000001c79b71$543e0970$fcba1c50$@com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Dismantling the lies...
From: sesser@hardened-php.net (Stefan Esser)


> The function call does strike me as completely unnecessary and the additional stack operations required are expensive. I'm willing to be that if the function was converted to a macro, the proposed solution would be a workable fix. Just my two cents; I'm not very experienced with the PHP internals yet.
>   
Like I said the patch was hacked in 30 minutes, to proove it is
possible. I am well aware that a function call is additional overhead.

Don't forget that the MOPB-1 issue was disclosed on the 1st March. This
was 2.5 months ago. 2.5 months vs. 30 minutes.
Additionally the PHP dev team knows this problem for YEARS and it was
the only possible solution to expose the problem during
the MOPB to get it ever fixed.

I am fully aware that it can be made faster. But a slow solution is
better than no solution at all.

Stefan Esser