Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29466
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 85.214.94.56 cause and error)
Date: Wed, 16 May 2007 16:14:36 +0200
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <506397651.20070516161436@marcus-boerger.de>
To: Raghubansh <softvirus@gmail.com>
CC: Zoe Slattery <zoe.slattery@googlemail.com>, 
	Stanislav Malyshev <stas@zend.com>, <internals@lists.php.net>, <helly@php.net>, 
	<antony@zend.com>
In-Reply-To: <5e2913440705160458v1255e17fv11f79820503c9cf@mail.gmail.com>
References: <464891C7.3040806@googlemail.com> <862412914.20070514193633@marcus-boerger.de> <46496335.5050403@googlemail.com> <5e2913440705150052l7bac4028sc3ac26655b38b141@mail.gmail.com> <464968C5.9060608@zend.com> <4649E549.8040303@zend.com> <464AA8A0.6030105@googlemail.com> <5e2913440705160458v1255e17fv11f79820503c9cf@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Tests - and a question
From: helly@php.net (Marcus Boerger)

Hello Raghubansh,

  if such a mapping becomes more important i'd say we go with a xml file
mapping maintained in either php-src or phpdoc cvs module. That way we do
not have to rename all files and loose history.

best regards
marcus

Wednesday, May 16, 2007, 1:58:42 PM, you wrote:

> Hello Zoe,
> It would be nice thing to have mapping between categorization of the
> functions in the php doc and the source/test tree structure but keeping the
> tree structure as per the source code is better thing to do. If i have got
> it right as of now the testcases are places based on the location of the
> source file. For example testcases testing functions in the
> ext/standard/array.c are placed in ext/standard/tests/array dir,
> ext/standard/tests/reg.c is placed in ext/standar/tests/reg/ dir and so on.
> Testcases for functions found in the Zend dir are placed in Zend/tests dir.
> It would be nice to have the following addition to ext/standard/tests dir
> with respect to variable handling functions ( varible handling funnctions
> are implemented by different source file,e.g : type.c, var.c,
> Zend/zend_builtin_functions.c, etc) :
>   A sub dir "type" (ext/standard/tests/type) where all the testcases testing
> functions in type.c can be placed, currently its placed in
> general_functions(ext/standard/tests/general_funtions) dir
>   A sub dir "var" (ext/standard/tests/var) where all the testcases testing
> functions in var.c can be placed, currently they are placed in
> general_functions(ext/standard/tests/general_functions) dir, and so on.

> Doing this way its makes is very easy for locating a testcase and give
> better dir structure for test organization. It would be nice if these
> details were documented on php.net, May be right place is qa.php.net under
> the doc "how to write test".

> Marcus, Tony and others, Any comments from you ?

> Also notice that we have done commit of some string functions(strcasecmp,
> strcmp, strncmp) in string dir, which should have been committed in
> Zend/tests dir because those functions are implemented by source file placed
> in Zend dir.

> Best Regards,
> Raghubansh, IBM India

> On 5/16/07, Zoe Slattery <zoe.slattery@googlemail.com> wrote:
>>
>> Stanislav Malyshev wrote:
>> > I think it does. If one needs to see which tests there are or are
>> > there any tests that test particular thing or inspect certain aspects
>> > of a functionality, navigating a maze of func_01234.phpt, all alike,
>> > is a nightmare. Of course, I could open all of them one by one and
>> > remember which one does what - that is if I were a being with
>> > unlimited lifespan, infallible memory and never felt bored - but for
>> > regular human it's a painful experience. So when writing a new tests
>> > it would be very good to give them names that make sense, it doesn't
>> > cost anything and helps people. Renaming old ones might be somewhat
>> > boring task, so not sure anybody ever would do that...
>> I'm happy to rename as we work through - if we can see an obvious and
>> more descriptive name. Also, what about making the test directory
>> structure match the functional reference for core functions? Some of it
>> does at the moment (strings, array) but it would be good to put all the
>> variable handling tests in ext/standard/tests/variable_handling for
>> example. It's another thing we could do as we go along...
>>
>> Zoe Slattery
>> IBM UK
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>



Best regards,
 Marcus