Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29449
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rajeczy.com from 195.188.213.5 cause and error)
Message-ID: <464A0049.50609@rajeczy.com>
Date: Tue, 15 May 2007 19:47:37 +0100
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: Emil Ivanov <emil.vladev@gmail.com>
CC:  internals@lists.php.net
References: <38.B7.39652.C93F9464@pb1.pair.com>
In-Reply-To: <38.B7.39652.C93F9464@pb1.pair.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] register_session_gc_handler proposal
From: arpad@rajeczy.com (Arpad Ray)

Emil Ivanov wrote:
> The case is simple:
> A user is allowed to upload files to the server, which are store in a 
> temporary location and their filenames are stored in the session.
> The user leaves the site and the session gets destroyed, but the files 
> remain untouched.
> If I can hook to the gc session function that will solve my case, but 
> currently with session_set_save_handler I have to rewrite session handling, 
> which I don't need...
> So a simple hook will be very useful.
Hi,

I've also been looking into how this could be implemented elegantly and 
I'd like to propose the following:

- Create a class exposed to userland called something like 
SessionDefaultHandler, which wraps the session module defined at startup.
- Alter session_set_save_handler() to alternatively take a single 
argument, a class name.
- The given handler class must extend SessionDefaultHandler and may 
override any of its methods.
- Alter the user session module to use the child class if it's been 
registered.

This would provide an elegant solution to your particular problem, as 
well as allowing any default session functions to be overridden, wrapped 
or called independently.

<?php
class MySessionHandler extends SessionDefaultHandler {
    function gc($maxlifetime)
    {
        parent::gc($maxlifetime);
        $time = time();
        foreach (glob('images/*') as $file) {
            if ($time - filemtime($file) > $maxlifetime) {
                unlink($file);
            }
        }
        return true;
    }
}
session_set_save_handler('MySessionHandler');
?>

Any thoughts?

Arpad