Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29431 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58139 invoked by uid 1010); 15 May 2007 08:45:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 58116 invoked from network); 15 May 2007 08:45:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 May 2007 08:45:19 -0000 Authentication-Results: pb1.pair.com header.from=zoe.slattery@googlemail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=zoe.slattery@googlemail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 64.233.184.229 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: zoe.slattery@googlemail.com X-Host-Fingerprint: 64.233.184.229 wr-out-0506.google.com Linux 2.4/2.6 Received: from [64.233.184.229] ([64.233.184.229:5979] helo=wr-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CD/D2-07106-C1379464 for ; Tue, 15 May 2007 04:45:19 -0400 Received: by wr-out-0506.google.com with SMTP id i21so2062635wra for ; Tue, 15 May 2007 01:45:11 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=dWy+oOHm6lrlCovlnHq+lLHIYvYi8sTeR3Y6/T9kIAzzYen+rDqWpXJXKM72Oug77e+G1C/RMqWHUBvDvGm9ufLfpaSuEsNgSRIsGn39UHqcBH0/sb5x/5RYMfbzUl4Eg/U2q7NECfQbAWqMew+/IaWpaJ/YiJR2Gf9xbN8CZ5s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=CZ+TZhoYUOcb9dHbvDsgu2laC+cmKpd5t1Yh/rtYAj66Q15ppfRw6sqyQ6YKC3rTXzUNvv1Vfh7a6KW5Gkijqy8xjLmFH77skO8b7corIsv2JDfVadi798ZhuCsDhW7FVRlXx/StND2VTxdz6eBVinTGfgBgY3JJ1dTjwkORoQA= Received: by 10.78.190.10 with SMTP id n10mr2542129huf.1179218700748; Tue, 15 May 2007 01:45:00 -0700 (PDT) Received: from ?9.20.191.73? ( [195.212.29.67]) by mx.google.com with ESMTP id k28sm1518261ugd.2007.05.15.01.44.59; Tue, 15 May 2007 01:45:00 -0700 (PDT) Message-ID: <4649730B.5020507@googlemail.com> Date: Tue, 15 May 2007 09:44:59 +0100 User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Antony Dovgal CC: internals@lists.php.net References: <464891C7.3040806@googlemail.com> <862412914.20070514193633@marcus-boerger.de> <46496335.5050403@googlemail.com> <5e2913440705150052l7bac4028sc3ac26655b38b141@mail.gmail.com> <464968C5.9060608@zend.com> In-Reply-To: <464968C5.9060608@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Tests - and a question From: zoe.slattery@googlemail.com (Zoe Slattery) Antony Dovgal wrote: > On 05/15/2007 11:52 AM, SoftVirus wrote: >> Hello Zoe, Marcus & Tony, >> >> Files names having _(basic|variation|error|object).phpt looks much >> better. >> File names _[0-9]*.phpt does not give much detail about what are the >> functions being testing by this testcase until one looks at the --TEST-- >> section of the file. It would be nice to have the name of the testcase >> accomodate name of the functions that are being tested. For example if >> 009.phpt is written to test basic functionality of current() and next() >> functions, the better file name could be current_next_basic.phpt. > > Well, aesthetically - yes, "current_next_basic" might look better to > those who don't like numbers. > But you still have to open the test and read its --TEST-- section > contents to learn what exactly it's testing. > > That said, I'm happy with both func_b.phpt and func_basic.phpt (and > even 009.phpt) =) > We just need more tests, doesn't matter what their names look like. > We're on it :-) Will probably have a few more questions on Unicode testing later, noticed that you are putting UEXPECT section in tests- but need to understand the implemenentation plan first...