Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29430
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <464968C5.9060608@zend.com>
Date: Tue, 15 May 2007 12:01:09 +0400
User-Agent: Thunderbird 2.0.0.0 (X11/20070326)
MIME-Version: 1.0
To: SoftVirus <softvirus@gmail.com>
CC: Zoe Slattery <zoe.slattery@googlemail.com>, 
 Marcus Boerger <helly@php.net>,
  kraghuba@in.ibm.com,  internals@lists.php.net
References: <464891C7.3040806@googlemail.com>	 <862412914.20070514193633@marcus-boerger.de>	 <46496335.5050403@googlemail.com> <5e2913440705150052l7bac4028sc3ac26655b38b141@mail.gmail.com>
In-Reply-To: <5e2913440705150052l7bac4028sc3ac26655b38b141@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Tests - and a question
From: antony@zend.com (Antony Dovgal)

On 05/15/2007 11:52 AM, SoftVirus wrote:
> Hello Zoe, Marcus &  Tony,
> 
> Files names having _(basic|variation|error|object).phpt looks much better.
> File names _[0-9]*.phpt does not give much detail about what are the
> functions being testing by this testcase until one looks at the --TEST--
> section of the file. 
> It would be nice to have the name of the testcase
> accomodate name of the functions that are being tested.  For example if
> 009.phpt is written to test basic functionality of current() and next()
> functions, the better file name could be current_next_basic.phpt.

Well, aesthetically - yes, "current_next_basic" might look better to those who don't like numbers.
But you still have to open the test and read its --TEST-- section contents to learn what exactly it's testing.

That said, I'm happy with both func_b.phpt and func_basic.phpt (and even 009.phpt) =)
We just need more tests, doesn't matter what their names look like.

-- 
Wbr, 
Antony Dovgal