Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain php.net from 85.214.94.56 cause and error)
Date: Mon, 14 May 2007 19:36:33 +0200
Reply-To: Marcus Boerger <helly@php.net>
Message-ID: <862412914.20070514193633@marcus-boerger.de>
To: Zoe Slattery <zoe.slattery@googlemail.com>
CC: internals@lists.php.net, antony@zend.com, kraghuba@in.ibm.com
In-Reply-To: <464891C7.3040806@googlemail.com>
References: <464891C7.3040806@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Tests - and a question
From: helly@php.net (Marcus Boerger)

Hello Zoe,

  that's pretty fine. Instead of _[bveo][0-9]?.phpt you could do
_(basic|variation|error|object)[0-9]{3}.phpt. Which is a tad bit better.
However those are just filenames helping you to find the correct test
file while developing. For that reason we didn not do so much about
generating those files. We Only made it briefly and suggested a three
digit numbering scheme. After all th ename in --TEST.. is the important
thing.

Thanks for the effort into test writing!!!

best regards
marcus
  
Monday, May 14, 2007, 6:43:51 PM, you wrote:

> Hi all

> We added a few tests for array, string and variable handling functions 
> at the weekend. As always - any feedback will be welcome.

> One thing we had some difficulty with was keeping the test output small 
> enough to be easily read. We chose to divide up tests like this:

>    test_name_b.phpt    b=basic function
>    test_name_v.phpt    v=variation
>    test_name_e.phpt    e=error cases
>    test_name_o.phpt    o=object specific

> This may not be the right scheme and I'm happy to change it if anyone 
> has better suggestions, although it is useful to seperate out the error 
> case tests because quite a lot of the differences between php5 and php6 
> seem to be in the exact form of the error message. Using this doesn't 
> completely solve the problem anyway - I think some of the "v" tests will 
> will end up being test_name_v1, test_name_v2 etc.


> Thanks, Zoe
> IBM UK




Best regards,
 Marcus