Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29413
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <46489650.4030009@zend.com>
Date: Mon, 14 May 2007 21:03:12 +0400
User-Agent: Thunderbird 2.0.0.0 (X11/20070326)
MIME-Version: 1.0
To: Zoe Slattery <zoe.slattery@googlemail.com>
CC:  internals@lists.php.net,  kraghuba@in.ibm.com
References: <464891C7.3040806@googlemail.com>
In-Reply-To: <464891C7.3040806@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Tests - and a question
From: antony@zend.com (Antony Dovgal)

On 05/14/2007 08:43 PM, Zoe Slattery wrote:
> Hi all
> 
> We added a few tests for array, string and variable handling functions 
> at the weekend. As always - any feedback will be welcome.
> 
> One thing we had some difficulty with was keeping the test output small 
> enough to be easily read. We chose to divide up tests like this:
> 
>    test_name_b.phpt    b=basic function
>    test_name_v.phpt    v=variation
>    test_name_e.phpt    e=error cases
>    test_name_o.phpt    o=object specific

That would work for me, though I don't really see much sense in this.
001.phpt, test_name_001.phpt, func_1.phpt, test_name_v.phpt - they're all cryptic enough 
and are not supposed to carry any information.
I believe they're just filenames and the _real_ test name is in the --TEST-- section.
 
> This may not be the right scheme and I'm happy to change it if anyone 
> has better suggestions, although it is useful to seperate out the error 
> case tests because quite a lot of the differences between php5 and php6 
> seem to be in the exact form of the error message. Using this doesn't 
> completely solve the problem anyway - I think some of the "v" tests will 
> will end up being test_name_v1, test_name_v2 etc.

I would personally prefer having more small tests with names like "001.phpt" than four 50kb "func_name_001_[b|v|e|0].phpt"..

-- 
Wbr, 
Antony Dovgal