Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29080
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender)
Message-ID: <463255F0.6060108@zend.com>
Date: Fri, 27 Apr 2007 23:58:40 +0400
User-Agent: Thunderbird 2.0.0.0 (X11/20070326)
MIME-Version: 1.0
To: Tyler Lawson <tyler@n49.com>
CC:  internals@lists.php.net
References: <200704271939.l3RJdkQG025948@server2.n49.com>
In-Reply-To: <200704271939.l3RJdkQG025948@server2.n49.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] JSON ampersand patch
From: antony@zend.com (Antony Dovgal)

On 04/27/2007 11:39 PM, Tyler Lawson wrote:
> Hello,
> 
> I hope this is the right place for this, as I'd like to post a patch for
> your consideration to the way the JSON handles ampersands.  I have had
> problems sending JSON data back and forth over POST requests, where an
> ampersand separates variables.  This patch will convert "&" into "\u0026",
> which will allow ampersands to travel freely and be parsed by any valid JSON
> decoder.

I believe a short reproduce case would explain it better.
 
> This has been applied against php-5.2.1
> 
> --- json.c      2007-01-12 07:17:32.000000000 -0500
> +++ my_json.c    2007-04-27 15:12:44.000000000 -0400
> @@ -301,6 +301,11 @@
>                      smart_str_appendl(buf, "\\t", 2);
>                  }
>                  break;
> +            case '&':
> +                {
> +                    smart_str_appendl(buf, "\\u0026", 6);
> +                }
> +                break;
>              default:
>                  {
>                      if (us < ' ' || (us & 127) == us)
> 
> 
> Tyler
> 


-- 
Wbr, 
Antony Dovgal