Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29060
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.114 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: quoted-printable
Date: Thu, 26 Apr 2007 14:49:00 -0700
Message-ID: <698DE66518E7CA45812BD18E807866CE2FE327@us-ex1.zend.net>
Thread-Topic: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings
Thread-Index: AceIJ5X2C0RUqp6CSUWGFuTXRiSkjgAJRimw
References: <00d201c77d07$dc0819f0$0201a8c0@pc1> <004201c787b6$588705f0$0201a8c0@pc1> <1667202369.20070426091902@marcus-boerger.de> <00d801c787e5$9119dbc0$0201a8c0@pc1> <98552C10-0912-4F54-A13D-04078B8A9BEB@gravitonic.com> <698DE66518E7CA45812BD18E807866CE2FE27E@us-ex1.zend.net> <1757349551.20070426192412@marcus-boerger.de>
To: "Marcus Boerger" <helly@php.net>
Cc: "Andrei Zmievski" <andrei@gravitonic.com>,
	"Matt Wilmas" <php_lists@realplain.com>,
	<internals@lists.php.net>
Subject: RE: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings
From: andi@zend.com ("Andi Gutmans")

Sure makes even more sense.=20

> -----Original Message-----
> From: Marcus Boerger [mailto:helly@php.net]=20
> Sent: Thursday, April 26, 2007 10:24 AM
> To: Andi Gutmans
> Cc: Andrei Zmievski; Matt Wilmas; internals@lists.php.net
> Subject: Re: [PHP-DEV] [PATCH] Major optimization for=20
> heredocs/interpolated strings
>=20
> Hello Andi,
>=20
>   how about you guys review/test it and then commit it if you=20
> agree to it?
>=20
> best regards
> marcus
>=20
> Thursday, April 26, 2007, 7:18:46 PM, you wrote:
>=20
> > Before you commit it, give us a few more days to review it.=20
> We need to=20
> > be careful before commiting major changes to the scanner.=20
> If it checks=20
> > out I'm definitely fine with commiting.
>=20
> > Andi
>=20
> >> -----Original Message-----
> >> From: Andrei Zmievski [mailto:andrei@gravitonic.com]
> >> Sent: Thursday, April 26, 2007 8:53 AM
> >> To: Matt Wilmas
> >> Cc: internals@lists.php.net; Marcus Boerger
> >> Subject: Re: [PHP-DEV] [PATCH] Major optimization for=20
> >> heredocs/interpolated strings
> >>=20
> >> On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote:
> >>=20
> >> > BTW, regarding HEAD, for you, Andrei, or anyone, I think I
> >> noticed a
> >> > bug, unrelated to my changes: CG(literal_type) isn't set
> >> for backticks
> >> > in the parser, so it winds up being whatever was last set. =20
> >> I would've
> >> > changed it, but didn't know if it's supposed to always be
> >> IS_STRING or
> >> > dependent on UG(unicode).
> >>=20
> >> Thanks, I remember leaving that out since we didn't have=20
> filesystem=20
> >> encoding support yet, but it's definitely should be there=20
> now. Fixed.
> >>=20
> >> Also, I'm for committing your patch to HEAD and 5.3.
> >>=20
> >> -Andrei
> >>=20
> >> --
> >> PHP Internals - PHP Runtime Development Mailing List To=20
> unsubscribe,=20
> >> visit: http://www.php.net/unsub.php
> >>=20
> >>=20
>=20
>=20
>=20
>=20
> Best regards,
>  Marcus
>=20
>=20