Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29056 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25668 invoked by uid 1010); 26 Apr 2007 17:23:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 25653 invoked from network); 26 Apr 2007 17:23:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Apr 2007 17:23:16 -0000 Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain php.net from 85.214.94.56 cause and error) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Received: from [85.214.94.56] ([85.214.94.56:39991] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CC/50-21548-300E0364 for ; Thu, 26 Apr 2007 13:23:15 -0400 Received: from baumbart.mbo (dslb-084-063-037-061.pools.arcor-ip.net [84.63.37.61]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 9F9161B3623; Thu, 26 Apr 2007 19:23:12 +0200 (CEST) Date: Thu, 26 Apr 2007 19:24:12 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1757349551.20070426192412@marcus-boerger.de> To: Andi Gutmans CC: Andrei Zmievski , Matt Wilmas , In-Reply-To: <698DE66518E7CA45812BD18E807866CE2FE27E@us-ex1.zend.net> References: <00d201c77d07$dc0819f0$0201a8c0@pc1> <004201c787b6$588705f0$0201a8c0@pc1> <1667202369.20070426091902@marcus-boerger.de> <00d801c787e5$9119dbc0$0201a8c0@pc1> <98552C10-0912-4F54-A13D-04078B8A9BEB@gravitonic.com> <698DE66518E7CA45812BD18E807866CE2FE27E@us-ex1.zend.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings From: helly@php.net (Marcus Boerger) Hello Andi, how about you guys review/test it and then commit it if you agree to it? best regards marcus Thursday, April 26, 2007, 7:18:46 PM, you wrote: > Before you commit it, give us a few more days to review it. We need to > be careful before commiting major changes to the scanner. If it checks > out I'm definitely fine with commiting. > Andi >> -----Original Message----- >> From: Andrei Zmievski [mailto:andrei@gravitonic.com] >> Sent: Thursday, April 26, 2007 8:53 AM >> To: Matt Wilmas >> Cc: internals@lists.php.net; Marcus Boerger >> Subject: Re: [PHP-DEV] [PATCH] Major optimization for >> heredocs/interpolated strings >> >> On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote: >> >> > BTW, regarding HEAD, for you, Andrei, or anyone, I think I >> noticed a >> > bug, unrelated to my changes: CG(literal_type) isn't set >> for backticks >> > in the parser, so it winds up being whatever was last set. >> I would've >> > changed it, but didn't know if it's supposed to always be >> IS_STRING or >> > dependent on UG(unicode). >> >> Thanks, I remember leaving that out since we didn't have >> filesystem encoding support yet, but it's definitely should >> be there now. Fixed. >> >> Also, I'm for committing your patch to HEAD and 5.3. >> >> -Andrei >> >> -- >> PHP Internals - PHP Runtime Development Mailing List To >> unsubscribe, visit: http://www.php.net/unsub.php >> >> Best regards, Marcus