Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:29054 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86610 invoked by uid 1010); 26 Apr 2007 16:03:10 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 86595 invoked from network); 26 Apr 2007 16:03:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Apr 2007 16:03:10 -0000 Authentication-Results: pb1.pair.com smtp.mail=antony@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=antony@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.162 as permitted sender) X-PHP-List-Original-Sender: antony@zend.com X-Host-Fingerprint: 212.25.124.162 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from [212.25.124.162] ([212.25.124.162:25829] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E9/55-42490-C3DC0364 for ; Thu, 26 Apr 2007 12:03:10 -0400 Received: (qmail 15394 invoked from network); 26 Apr 2007 16:03:05 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 26 Apr 2007 16:03:05 -0000 Message-ID: <4630CD39.7050606@zend.com> Date: Thu, 26 Apr 2007 20:03:05 +0400 User-Agent: Thunderbird 2.0.0.0 (X11/20070326) MIME-Version: 1.0 To: Andrei Zmievski CC: Matt Wilmas , internals@lists.php.net, Marcus Boerger References: <00d201c77d07$dc0819f0$0201a8c0@pc1> <004201c787b6$588705f0$0201a8c0@pc1> <1667202369.20070426091902@marcus-boerger.de> <00d801c787e5$9119dbc0$0201a8c0@pc1> <98552C10-0912-4F54-A13D-04078B8A9BEB@gravitonic.com> In-Reply-To: <98552C10-0912-4F54-A13D-04078B8A9BEB@gravitonic.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings From: antony@zend.com (Antony Dovgal) On 04/26/2007 07:53 PM, Andrei Zmievski wrote: > On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote: > >> BTW, regarding HEAD, for you, Andrei, or anyone, I think I noticed >> a bug, >> unrelated to my changes: CG(literal_type) isn't set for backticks >> in the >> parser, so it winds up being whatever was last set. I would've >> changed it, >> but didn't know if it's supposed to always be IS_STRING or >> dependent on >> UG(unicode). > > Thanks, I remember leaving that out since we didn't have filesystem > encoding support yet, but it's definitely should be there now. Fixed. > > Also, I'm for committing your patch to HEAD and 5.3. 5.what?? -- Wbr, Antony Dovgal