Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:29052
Return-Path: <andrei@gravitonic.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 78909 invoked by uid 1010); 26 Apr 2007 15:51:27 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 78894 invoked from network); 26 Apr 2007 15:51:27 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 26 Apr 2007 15:51:27 -0000
Authentication-Results: pb1.pair.com smtp.mail=andrei@gravitonic.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=andrei@gravitonic.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain gravitonic.com from 204.11.219.139 cause and error)
X-PHP-List-Original-Sender: andrei@gravitonic.com
X-Host-Fingerprint: 204.11.219.139 mail.lerdorf.com  
Received: from [204.11.219.139] ([204.11.219.139:52123] helo=mail.lerdorf.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 58/84-42490-D7AC0364 for <internals@lists.php.net>; Thu, 26 Apr 2007 11:51:26 -0400
Received: from [66.228.175.145] (borndress-lm.corp.yahoo.com [66.228.175.145])
	(authenticated bits=0)
	by mail.lerdorf.com (8.13.8/8.13.8/Debian-3) with ESMTP id l3QFpKgW006859;
	Thu, 26 Apr 2007 08:51:21 -0700
In-Reply-To: <00d801c787e5$9119dbc0$0201a8c0@pc1>
References: <00d201c77d07$dc0819f0$0201a8c0@pc1> <004201c787b6$588705f0$0201a8c0@pc1> <1667202369.20070426091902@marcus-boerger.de> <00d801c787e5$9119dbc0$0201a8c0@pc1>
Mime-Version: 1.0 (Apple Message framework v752.2)
X-Priority: 3
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <98552C10-0912-4F54-A13D-04078B8A9BEB@gravitonic.com>
Cc: <internals@lists.php.net>, "Marcus Boerger" <helly@php.net>
Content-Transfer-Encoding: 7bit
Date: Thu, 26 Apr 2007 08:53:28 -0700
To: Matt Wilmas <php_lists@realplain.com>
X-Mailer: Apple Mail (2.752.2)
X-Virus-Scanned: ClamAV 0.90.2/3165/Thu Apr 26 06:03:24 2007 on colo
X-Virus-Status: Clean
Subject: Re: [PHP-DEV] [PATCH] Major optimization for heredocs/interpolated strings
From: andrei@gravitonic.com (Andrei Zmievski)

On Apr 26, 2007, at 2:30 AM, Matt Wilmas wrote:

> BTW, regarding HEAD, for you, Andrei, or anyone, I think I noticed  
> a bug,
> unrelated to my changes: CG(literal_type) isn't set for backticks  
> in the
> parser, so it winds up being whatever was last set.  I would've  
> changed it,
> but didn't know if it's supposed to always be IS_STRING or  
> dependent on
> UG(unicode).

Thanks, I remember leaving that out since we didn't have filesystem  
encoding support yet, but it's definitely should be there now. Fixed.

Also, I'm for committing your patch to HEAD and 5.3.

-Andrei