Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28889 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94747 invoked by uid 1010); 17 Apr 2007 15:01:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 94732 invoked from network); 17 Apr 2007 15:01:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Apr 2007 15:01:31 -0000 Authentication-Results: pb1.pair.com smtp.mail=rrichards@ctindustries.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=rrichards@ctindustries.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain ctindustries.net from 216.117.147.250 cause and error) X-PHP-List-Original-Sender: rrichards@ctindustries.net X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.5 (sometimes 2.4) (4) Received: from [216.117.147.250] ([216.117.147.250:54887] helo=ctindustries.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 08/BA-14509-941E4264 for ; Tue, 17 Apr 2007 11:01:31 -0400 Received: from [127.0.0.1] ([66.186.171.203]) (authenticated bits=0) by ctindustries.net (8.13.8/8.13.8) with ESMTP id l3HF03GB015173; Tue, 17 Apr 2007 11:00:04 -0400 Message-ID: <4624E0E7.9000109@ctindustries.net> Date: Tue, 17 Apr 2007 10:59:51 -0400 User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: RQuadling@googlemail.com CC: "William A. Rowe, Jr." , Ilia Alshanetsky , Rasmus Lerdorf , Matt Wilmas , internals@lists.php.net References: <007b01c77735$89410420$0201a8c0@pc1> <46155EC9.1020402@ctindustries.net> <10845a340704130333i17921209pad4538b5a3a43e7@mail.gmail.com> <3FD3996A-6E63-44BF-88EF-CEB174254995@prohost.org> <10845a340704130642w7c4edf5an8bc41d49c4e1dd86@mail.gmail.com> <4620B813.8080306@ctindustries.net> <10845a340704160155o18e0ef3dj135113d835e633d4@mail.gmail.com> <462365B9.9090502@rowe-clan.net> <10845a340704160507s3a76c55en857999cab90feabe@mail.gmail.com> <46238C3A.8090107@rowe-clan.net> <10845a340704160753w111dbfa6mf1e8275cec11a19b@mail.gmail.com> In-Reply-To: <10845a340704160753w111dbfa6mf1e8275cec11a19b@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------080904050200070709090908" X-Antivirus: avast! (VPS 000734-1, 04/17/2007), Outbound message X-Antivirus-Status: Clean X-Virus-Scanned: ClamAV version 0.90.1, clamav-milter version 0.90.1 on localhost X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=4.4 tests=AWL autolearn=disabled version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on ctindustries.net Subject: Re: [PHP-DEV] Build failure From: rrichards@ctindustries.net (Rob Richards) --------------080904050200070709090908 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Unless anyone sees a way to do this without adding the lock, I'd like to commit this patch. It adds a php_flock call only for windows. In doing so I got rid of the win32/flock files and now compile with flock_compat from main. Rob Richard Quadling wrote: > The testing I'm using is to launch multiple copies of the same PHP > script simultaneously using php.exe (CLI mode). This could easily be > multiple FastCGI scripts or multiple ISAPI threads. > > On 16/04/07, William A. Rowe, Jr. wrote: >> Richard Quadling wrote: >> > So isn't locking the solution for Windows? >> >> If this is single writer process, even with multithreads - a mutex >> is most efficient, otherwise with concurrent writer processes, file >> locking makes the most sense. >> >> Bill >> > > --------------080904050200070709090908 Content-Type: text/plain; name="php5_2.patch.txt" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="php5_2.patch.txt" SW5kZXg6IGV4dC9zdGFuZGFyZC9jb25maWcudzMyDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL3JlcG9zaXRvcnkvcGhwLXNyYy9leHQvc3RhbmRhcmQvY29uZmlnLnczMix2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNC4yLjINCmRpZmYgLXUgLXIxLjQuMi4yIGNvbmZpZy53MzIN Ci0tLSBleHQvc3RhbmRhcmQvY29uZmlnLnczMgk0IEphbiAyMDA2IDIxOjMxOjI5IC0wMDAw CTEuNC4yLjINCisrKyBleHQvc3RhbmRhcmQvY29uZmlnLnczMgkxNyBBcHIgMjAwNyAxMToz NDoxNiAtMDAwMA0KQEAgLTE2LDUgKzE2LDUgQEANCiAJdXJsX3NjYW5uZXJfZXguYyBmdHBf Zm9wZW5fd3JhcHBlci5jIGh0dHBfZm9wZW5fd3JhcHBlci5jIFwNCiAJcGhwX2ZvcGVuX3dy YXBwZXIuYyBjcmVkaXRzLmMgY3NzLmMgdmFyX3Vuc2VyaWFsaXplci5jIGZ0b2suYyBzaGEx LmMgXA0KIAl1c2VyX2ZpbHRlcnMuYyB1dWVuY29kZS5jIGZpbHRlcnMuYyBwcm9jX29wZW4u YyBcDQotCXN0cmVhbXNmdW5jcy5jIGh0dHAuYyIsIGZhbHNlIC8qIG5ldmVyIHNoYXJlZCAq Lyk7DQorCXN0cmVhbXNmdW5jcy5jIGh0dHAuYyBmbG9ja19jb21wYXQuYyIsIGZhbHNlIC8q IG5ldmVyIHNoYXJlZCAqLyk7DQogDQpJbmRleDogbWFpbi9tYWluLmMNCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0NClJDUyBmaWxlOiAvcmVwb3NpdG9yeS9waHAtc3JjL21haW4vbWFpbi5jLHYNCnJldHJp ZXZpbmcgcmV2aXNpb24gMS42NDAuMi4yMy4yLjM0DQpkaWZmIC11IC1yMS42NDAuMi4yMy4y LjM0IG1haW4uYw0KLS0tIG1haW4vbWFpbi5jCTE2IEFwciAyMDA3IDA4OjA5OjU2IC0wMDAw CTEuNjQwLjIuMjMuMi4zNA0KKysrIG1haW4vbWFpbi5jCTE3IEFwciAyMDA3IDExOjQ5OjQ5 IC0wMDAwDQpAQCAtNjMsNiArNjMsNyBAQA0KICNpZmRlZiBQSFBfV0lOMzINCiAjaW5jbHVk ZSA8aW8uaD4NCiAjaW5jbHVkZSAid2luMzIvcGhwX3JlZ2lzdHJ5LmgiDQorI2luY2x1ZGUg ImV4dC9zdGFuZGFyZC9mbG9ja19jb21wYXQuaCINCiAjZW5kaWYNCiAjaW5jbHVkZSAicGhw X3N5c2xvZy5oIg0KICNpbmNsdWRlICJaZW5kL3plbmRfZXhjZXB0aW9ucy5oIg0KQEAgLTM2 Miw4ICszNjMsMTEgQEANCiAJCQl0aW1lKCZlcnJvcl90aW1lKTsNCiAJCQlzdHJmdGltZShl cnJvcl90aW1lX3N0ciwgc2l6ZW9mKGVycm9yX3RpbWVfc3RyKSwgIiVkLSViLSVZICVIOiVN OiVTIiwgcGhwX2xvY2FsdGltZV9yKCZlcnJvcl90aW1lLCAmdG1idWYpKTsNCiAJCQlsZW4g PSBzcHByaW50ZigmdG1wLCAwLCAiWyVzXSAlcyVzIiwgZXJyb3JfdGltZV9zdHIsIGxvZ19t ZXNzYWdlLCBQSFBfRU9MKTsNCisjaWZkZWYgUEhQX1dJTjMyDQorCQkJcGhwX2Zsb2NrKGZk LCAyKTsNCisjZW5kaWYNCiAJCQl3cml0ZShmZCwgdG1wLCBsZW4pOw0KLQkJCWVmcmVlKHRt cCk7IA0KKwkJCWVmcmVlKHRtcCk7DQogCQkJY2xvc2UoZmQpOw0KIAkJCXJldHVybjsNCiAJ CX0NCkluZGV4OiB3aW4zMi9idWlsZC9jb25maWcudzMyDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg ZmlsZTogL3JlcG9zaXRvcnkvcGhwLXNyYy93aW4zMi9idWlsZC9jb25maWcudzMyLHYNCnJl dHJpZXZpbmcgcmV2aXNpb24gMS40MC4yLjguMi45DQpkaWZmIC11IC1yMS40MC4yLjguMi45 IGNvbmZpZy53MzINCi0tLSB3aW4zMi9idWlsZC9jb25maWcudzMyCTE2IEFwciAyMDA3IDA4 OjA5OjU2IC0wMDAwCTEuNDAuMi44LjIuOQ0KKysrIHdpbjMyL2J1aWxkL2NvbmZpZy53MzIJ MTcgQXByIDIwMDcgMTE6Mzk6MDUgLTAwMDANCkBAIC0zMDksNyArMzA5LDcgQEANCiBBRERf U09VUkNFUygibWFpbi9zdHJlYW1zIiwgInN0cmVhbXMuYyBjYXN0LmMgbWVtb3J5LmMgZmls dGVyLmMgcGxhaW5fd3JhcHBlci5jIFwNCiAJdXNlcnNwYWNlLmMgdHJhbnNwb3J0cy5jIHhw X3NvY2tldC5jIG1tYXAuYyIpOw0KIA0KLUFERF9TT1VSQ0VTKCJ3aW4zMiIsICJjcnlwdF93 aW4zMi5jIGZsb2NrLmMgZ2xvYi5jIG1kNWNyeXB0LmMgcmVhZGRpci5jIFwNCitBRERfU09V UkNFUygid2luMzIiLCAiY3J5cHRfd2luMzIuYyBnbG9iLmMgbWQ1Y3J5cHQuYyByZWFkZGly LmMgXA0KIAlyZWdpc3RyeS5jIHNlbGVjdC5jIHNlbmRtYWlsLmMgdGltZS5jIHdmaWxlLmMg d2ludXRpbC5jIHdzeXNsb2cuYyBnbG9iYWxzLmMiKTsNCiANCiBBRERfU09VUkNFUygicmVn ZXgiLCAicmVnY29tcC5jIHJlZ2Vycm9yLmMgcmVnZXhlYy5jIHJlZ2ZyZWUuYyIpOw0K --------------080904050200070709090908--