Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28722
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rajeczy.com from 195.188.213.5 cause and error)
Message-ID: <461A4278.8070706@rajeczy.com>
Date: Mon, 09 Apr 2007 14:41:12 +0100
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To:  internals@lists.php.net
References: <4617A86C.3030007@rajeczy.com>
In-Reply-To: <4617A86C.3030007@rajeczy.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] magic_quotes_gpc behaviour
From: arpad@rajeczy.com (Arpad Ray)

Arpad Ray wrote:
> So, is this behaviour deliberate, and if so, what's the rationale?
>

The problem seems to be in (5.2.x CVS) php_variables.c, lines 161-166:

                if (PG(magic_quotes_gpc) && (index != var)) {
                    /* no need to addslashes() the index if it's the 
main variable name */
                    escaped_index = php_addslashes(index, index_len, 
&index_len, 0 TSRMLS_CC);
                } else {
                    escaped_index = index;
                }

If "&& (index != var)" is removed, all keys are escaped as expected. The 
equivalent line for keys of scalar variables (198) lacks this check 
since 5.0.0, and since then it has escaped them correctly. It's still 
there in the 4.4 branch.

Is there any reason not to remove this check, at least in the 5.2 branch?

Arpad