Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:28698 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3240 invoked by uid 1010); 6 Apr 2007 04:39:49 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 3225 invoked from network); 6 Apr 2007 04:39:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Apr 2007 04:39:49 -0000 Authentication-Results: pb1.pair.com header.from=frank@kromann.info; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=frank@kromann.info; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain kromann.info designates 64.186.239.125 as permitted sender) X-PHP-List-Original-Sender: frank@kromann.info X-Host-Fingerprint: 64.186.239.125 c-064-186-239-125.oc1.redwire.net Linux 2.5 (sometimes 2.4) (4) Received: from [64.186.239.125] ([64.186.239.125:49294] helo=mail.kromann.info) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3E/CD-13039-51FC5164 for ; Fri, 06 Apr 2007 00:39:49 -0400 Received: by mail.kromann.info (Postfix, from userid 510) id EC0164040C9; Thu, 5 Apr 2007 21:39:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on mail.kromann.info X-Spam-Level: X-Spam-Status: No, score=-0.4 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.1.7 Received: from warp (www.kromann.info [64.186.239.115]) by mail.kromann.info (Postfix) with SMTP id 69FD2404058; Thu, 5 Apr 2007 21:39:46 -0700 (PDT) To: Rasmus Lerdorf Cc: X-Mailer: Swwwing 2000 Message-ID: <11758343895720000@9866357972520000.9866341568840000> MIME-Version: 1.0 Reply-To: "Frank M. Kromann" Date: Thu, 05 Apr 2007 21:39:49 -0700 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] flock() php_flock() compile problems From: frank@kromann.info ("Frank M. Kromann") Hi Rasmus, But the definition of flock in win32/flock.c() is identical to the definition of php_flock() in ext/standard/flock_compat.c. I don't see any reason to hae the same function defined twice with two different names. - Frank > Frank M. Kromann wrote: > > Hello Everyone, > > > > I hope I'm not too far off here but getting rid of flock.c in > > win32\build\config.w32 an adding flock_compat to ext\standard\config.w32 > > seams to solve the compile problems, at least in the 5.2 branch. > > Rob tracked it down to the fact that it was using stdio. I hadn't > realized that. So, the fix is to use VCWD_OPEN_MODE instead of FOPEN > and a write() instead of the fprintf. > > -Rasmus > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >