Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28686
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 66.249.92.171 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=beta;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=MM0sS972/hGVqSaYtbRmJnt5xFWSqnqWw0BjpiUOFF6yEBBaGUL1yXvkCInhG5hBQ2ioCHmNzUnAmQ1FIE2kNpVVCN43K5vS2Urvmpu2xj29FtooW/XoyxR1Zek5ZH4JEeICYZTlkQHEHsPyC4qxxhI7q9lKnUAwOeKPfVaipqY=
Message-ID: <10845a340704050742n38ef04c0t7f6f2ad85e2711b5@mail.gmail.com>
Date: Thu, 5 Apr 2007 15:42:49 +0100
Reply-To: RQuadling@GoogleMail.com
To: "Ilia Alshanetsky" <ilia@prohost.org>
Cc: "Rasmus Lerdorf" <rasmus@lerdorf.com>, 
	"Matt Wilmas" <php_lists@realplain.com>, internals@lists.php.net
In-Reply-To: <646617A7-86A7-4E64-94CE-8E5D5766741A@prohost.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <007b01c77735$89410420$0201a8c0@pc1> <46148933.7030709@lerdorf.com>
	 <646617A7-86A7-4E64-94CE-8E5D5766741A@prohost.org>
Subject: Re: [PHP-DEV] Build failure
From: rquadling@googlemail.com ("Richard Quadling")

Using PHP 5.2.2-dev (cli) (built: Mar 23 2007 07:02:57) I can
replicate the problem on Windows.

Using this single line command at the CMD prompt:

for %x in (A B C D E F G H I J K L M N O P Q R S T U V W X Y Z) do
start php -r "ini_set('error_log','/tmp/test.log');for($i=0;$i<100;$i++)error_log(str_repeat('%x',5000));"

The log file has many broken lines.

On 05/04/07, Ilia Alshanetsky <ilia@prohost.org> wrote:
> Rasmus,
>
> Sorry for the delay in the reply. According to my tests on linux
> using the sample script provided by the original bug reporter having
> no lock causes a problem when the error message is >4k in length. In
> this case multiple buffers are used and corruption can happen (it did
> on a dual cpu machine with 10 error log writing threads running),
> which is why I feel the lock is needed.
>
>
> On 5-Apr-07, at 1:29 AM, Rasmus Lerdorf wrote:
>
> > Matt Wilmas wrote:
> >> Hi,
> >>
> >> Maybe just a Windows problem if it wasn't noticed yet, but I was
> >> compiling
> >> the latest 5.2 snapshot and got:
> >>
> >> main.obj : error LNK2019: unresolved external symbol _php_flock
> >> referenced
> >> in function _php_log_err
> >> Release_TS\php5ts.dll : fatal error LNK1120: 1 unresolved externals
> >>
> >> Caused by this recent commit, http://news.php.net/php.cvs/43683,
> >> and I
> >> commented the php_flock line as a workaround.  The Windows 5.2
> >> snapshots
> >> haven't been updated because of this either, of course.
> >
> > I see no reason for that lock at all as I commented when this was
> > committed, but Ilia never replied.  This is a single write
> > operation now
> > since those fprintf's are now one, so that part of the fix is good,
> > but
> > the lock call is not needed since single writes in append mode are
> > atomic, even on Windows.
> >
> > So, your work around is fine and should actually be committed.
> >
> > -Rasmus
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>
> Ilia Alshanetsky
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"