Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28682
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 66.249.92.171 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=beta;
        h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=aOhmgFlaMLoLXEv51uZxM+oXLxDx/K2PG1Cnah0M1cNbJ88Sl64tnFTCANY0+aev+m1cLV/T1PgW9C7xHFdI42+FxrL4kOqR5L288iH21ViY+5qu+lRgb73N1NDmoj0qYBKXWYsc7yY9QX3yOGyHdaq/KI4CzAzZEGMAzprFa4Y=
Message-ID: <10845a340704050347k1507ec37qd6b243206aa13ba4@mail.gmail.com>
Date: Thu, 5 Apr 2007 11:47:20 +0100
Reply-To: RQuadling@GoogleMail.com
To: "Rasmus Lerdorf" <rasmus@lerdorf.com>
Cc: "Matt Wilmas" <php_lists@realplain.com>, internals@lists.php.net
In-Reply-To: <46148933.7030709@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <007b01c77735$89410420$0201a8c0@pc1> <46148933.7030709@lerdorf.com>
Subject: Re: [PHP-DEV] Build failure
From: rquadling@googlemail.com ("Richard Quadling")

http://rquadling.php1h.com/main.c.diff.txt for HEAD. I don't know how
to patch a specific version.


On 05/04/07, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:
> Matt Wilmas wrote:
> > Hi,
> >
> > Maybe just a Windows problem if it wasn't noticed yet, but I was compiling
> > the latest 5.2 snapshot and got:
> >
> > main.obj : error LNK2019: unresolved external symbol _php_flock referenced
> > in function _php_log_err
> > Release_TS\php5ts.dll : fatal error LNK1120: 1 unresolved externals
> >
> > Caused by this recent commit, http://news.php.net/php.cvs/43683, and I
> > commented the php_flock line as a workaround.  The Windows 5.2 snapshots
> > haven't been updated because of this either, of course.
>
> I see no reason for that lock at all as I commented when this was
> committed, but Ilia never replied.  This is a single write operation now
> since those fprintf's are now one, so that part of the fix is good, but
> the lock call is not needed since single writes in append mode are
> atomic, even on Windows.
>
> So, your work around is fine and should actually be committed.
>
> -Rasmus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"