Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:28681
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <46148933.7030709@lerdorf.com>
Date: Wed, 04 Apr 2007 22:29:23 -0700
User-Agent: Thunderbird 1.5.0.10 (Macintosh/20070221)
MIME-Version: 1.0
To: Matt Wilmas <php_lists@realplain.com>
CC: internals@lists.php.net
References: <007b01c77735$89410420$0201a8c0@pc1>
In-Reply-To: <007b01c77735$89410420$0201a8c0@pc1>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Build failure
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Matt Wilmas wrote:
> Hi,
> 
> Maybe just a Windows problem if it wasn't noticed yet, but I was compiling
> the latest 5.2 snapshot and got:
> 
> main.obj : error LNK2019: unresolved external symbol _php_flock referenced
> in function _php_log_err
> Release_TS\php5ts.dll : fatal error LNK1120: 1 unresolved externals
> 
> Caused by this recent commit, http://news.php.net/php.cvs/43683, and I
> commented the php_flock line as a workaround.  The Windows 5.2 snapshots
> haven't been updated because of this either, of course.

I see no reason for that lock at all as I commented when this was
committed, but Ilia never replied.  This is a single write operation now
since those fprintf's are now one, so that part of the fix is good, but
the lock call is not needed since single writes in append mode are
atomic, even on Windows.

So, your work around is fine and should actually be committed.

-Rasmus